phy: marvell: phy-armada38x-comphy: Add of_node_put() before return

Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a return from the middle of the loop, there is
no put, thus causing a memory leak. Hence add an of_node_put before the
return.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

diff --git a/drivers/phy/marvell/phy-armada38x-comphy.c b/drivers/phy/marvell/phy-armada38x-comphy.c
index 3e00bc679d4ef29c6379005a2985d411cc11fdd5..6960dfd8ad8c985f34e5a08c4361f20224d2fd36 100644 (file)
--- a/drivers/phy/marvell/phy-armada38x-comphy.c
+++ b/drivers/phy/marvell/phy-armada38x-comphy.c
@@ -200,8 +200,10 @@ static int a38x_comphy_probe(struct platform_device *pdev)
                }
 
                phy = devm_phy_create(&pdev->dev, child, &a38x_comphy_ops);
-               if (IS_ERR(phy))
+               if (IS_ERR(phy)) {
+                       of_node_put(child);
                        return PTR_ERR(phy);
+               }
 
                priv->lane[val].base = base + 0x28 * val;
                priv->lane[val].priv = priv;