]> git.proxmox.com Git - mirror_qemu.git/commitdiff
qcow2: Fix segfault on zero-length write
authorKevin Wolf <kwolf@redhat.com>
Mon, 14 Jan 2013 16:31:31 +0000 (17:31 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Tue, 15 Jan 2013 08:08:55 +0000 (09:08 +0100)
One of the recent refactoring patches (commit f50f88b9) didn't take care
to initialise l2meta properly, so with zero-length writes, which don't
even enter the write loop, qemu just segfaulted.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block/qcow2.c

index d603f98a9c3b43d9080c14052c248a17411e2a54..f6abff6111e01785df486c0902bc03acd973861e 100644 (file)
@@ -759,7 +759,7 @@ static coroutine_fn int qcow2_co_writev(BlockDriverState *bs,
     QEMUIOVector hd_qiov;
     uint64_t bytes_done = 0;
     uint8_t *cluster_data = NULL;
-    QCowL2Meta *l2meta;
+    QCowL2Meta *l2meta = NULL;
 
     trace_qcow2_writev_start_req(qemu_coroutine_self(), sector_num,
                                  remaining_sectors);