]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
drm/i915/gvt: return error on cmd access
authorZhao Yan <yan.y.zhao@intel.com>
Wed, 1 Aug 2018 04:15:48 +0000 (00:15 -0400)
committerZhenyu Wang <zhenyuw@linux.intel.com>
Tue, 14 Aug 2018 07:26:39 +0000 (15:26 +0800)
If a register is not cmd accessible, should not just print error
message. Return error here so as not to deliver this cmd.

v2: return -EBADRQC to align with return value elsewhere. (kevin tian)

Signed-off-by: Zhao Yan <yan.y.zhao@intel.com>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
drivers/gpu/drm/i915/gvt/cmd_parser.c

index 45e89b1e048183164e218c5aa868dca458ab93a4..a614db310ea276a5deca674363c09db44e79ac79 100644 (file)
@@ -874,7 +874,7 @@ static int cmd_reg_handler(struct parser_exec_state *s,
        if (!intel_gvt_mmio_is_cmd_access(gvt, offset)) {
                gvt_vgpu_err("%s access to non-render register (%x)\n",
                                cmd, offset);
-               return 0;
+               return -EBADRQC;
        }
 
        if (is_shadowed_mmio(offset)) {