]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
ASoC: ep93xx-ac97: Fix platform_get_irq's error checking
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Wed, 29 Nov 2017 16:17:10 +0000 (21:47 +0530)
committerMark Brown <broonie@kernel.org>
Fri, 1 Dec 2017 13:04:51 +0000 (13:04 +0000)
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/cirrus/ep93xx-ac97.c

index bbf7a9266a991a0479d990ab803b9595fa2ffe2c..cd5a939ad6081a2394f3acbc5a030a99d5790310 100644 (file)
@@ -365,7 +365,7 @@ static int ep93xx_ac97_probe(struct platform_device *pdev)
 {
        struct ep93xx_ac97_info *info;
        struct resource *res;
-       unsigned int irq;
+       int irq;
        int ret;
 
        info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
@@ -378,8 +378,8 @@ static int ep93xx_ac97_probe(struct platform_device *pdev)
                return PTR_ERR(info->regs);
 
        irq = platform_get_irq(pdev, 0);
-       if (!irq)
-               return -ENODEV;
+       if (irq <= 0)
+               return irq < 0 ? irq : -ENODEV;
 
        ret = devm_request_irq(&pdev->dev, irq, ep93xx_ac97_interrupt,
                               IRQF_TRIGGER_HIGH, pdev->name, info);