]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
brcmfmac: set interface carrier to off by default
authorRafał Miłecki <rafal@milecki.pl>
Tue, 10 Dec 2019 11:35:55 +0000 (12:35 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 18 Dec 2019 19:05:26 +0000 (21:05 +0200)
It's important as brcmfmac creates one main interface for each PHY and
doesn't allow deleting it. Not setting carrier could result in other
subsystems misbehaving (e.g. LEDs "netdev" trigger turning LED on).

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c

index 85cf96461ddeb0808f723094cbb00ca39723a311..d3ddd97fe76800acfcd27566ff22bcb657462c54 100644 (file)
@@ -661,6 +661,8 @@ int brcmf_net_attach(struct brcmf_if *ifp, bool rtnl_locked)
                goto fail;
        }
 
+       netif_carrier_off(ndev);
+
        ndev->priv_destructor = brcmf_cfg80211_free_netdev;
        brcmf_dbg(INFO, "%s: Broadcom Dongle Host Driver\n", ndev->name);
        return 0;