]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
net: caif: fix misleading indentation
authorArnd Bergmann <arnd@arndb.de>
Mon, 14 Mar 2016 14:18:38 +0000 (15:18 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 14 Mar 2016 17:09:50 +0000 (13:09 -0400)
gcc points out code that is not indented the way it is
interpreted:

net/caif/cfpkt_skbuff.c: In function 'cfpkt_setlen':
net/caif/cfpkt_skbuff.c:289:4: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation]
    return cfpkt_getlen(pkt);
    ^~~~~~
net/caif/cfpkt_skbuff.c:286:3: note: ...this 'else' clause, but it is not
   else
   ^~~~

It is clear from the context that not returning here would be
a bug, as we'd end up passing a negative length into a function
that takes a u16 length, so it is not missing curly braces
here, and I'm assuming that the indentation is the only part
that's wrong about it.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/caif/cfpkt_skbuff.c

index f6c3b2137eeaacdc5cf38d1eac03e018d8f2d37b..59ce1fcc220ce0a71fb57733be7cc91e6b8ac7fc 100644 (file)
@@ -286,7 +286,7 @@ int cfpkt_setlen(struct cfpkt *pkt, u16 len)
                else
                        skb_trim(skb, len);
 
-                       return cfpkt_getlen(pkt);
+               return cfpkt_getlen(pkt);
        }
 
        /* Need to expand SKB */