]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
staging: unisys: visorbus: Remove gotos in visorbus_match
authorDavid Kershner <david.kershner@unisys.com>
Sun, 13 Mar 2016 02:27:11 +0000 (21:27 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 28 Mar 2016 14:30:36 +0000 (07:30 -0700)
Gotos in visorbus_match are not needed.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Timothy Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visorbus/visorbus_main.c

index 816a16dea7635a592abbec722fabfd6dddc57977..b31c44f8043f90f56b49eae6056aa579f27b93f5 100644 (file)
@@ -182,7 +182,6 @@ static int
 visorbus_match(struct device *xdev, struct device_driver *xdrv)
 {
        uuid_le channel_type;
-       int rc = 0;
        int i;
        struct visor_device *dev;
        struct visor_driver *drv;
@@ -190,26 +189,23 @@ visorbus_match(struct device *xdev, struct device_driver *xdrv)
        dev = to_visor_device(xdev);
        drv = to_visor_driver(xdrv);
        channel_type = visorchannel_get_uuid(dev->visorchannel);
-       if (visorbus_forcematch) {
-               rc = 1;
-               goto away;
-       }
-       if (visorbus_forcenomatch)
-               goto away;
 
+       if (visorbus_forcematch)
+               return 1;
+       if (visorbus_forcenomatch)
+               return 0;
        if (!drv->channel_types)
-               goto away;
+               return 0;
+
        for (i = 0;
             (uuid_le_cmp(drv->channel_types[i].guid, NULL_UUID_LE) != 0) ||
             (drv->channel_types[i].name);
             i++)
                if (uuid_le_cmp(drv->channel_types[i].guid,
-                               channel_type) == 0) {
-                       rc = i + 1;
-                       goto away;
-               }
-away:
-       return rc;
+                               channel_type) == 0)
+                       return i + 1;
+
+       return 0;
 }
 
 /** This is called when device_unregister() is called for the bus device