]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
power: reset: at91-sama5d2_shdwc: Remove redundant error printing in at91_shdwc_probe()
authorZhen Lei <thunder.leizhen@huawei.com>
Tue, 11 May 2021 09:49:19 +0000 (17:49 +0800)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Fri, 4 Jun 2021 11:04:01 +0000 (13:04 +0200)
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/reset/at91-sama5d2_shdwc.c

index 125e592af445e32d5b03e9ca950e556998cdd7ae..d8ecffe72f165cb9f0c4b04ab559a3475ae42491 100644 (file)
@@ -351,10 +351,8 @@ static int __init at91_shdwc_probe(struct platform_device *pdev)
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        at91_shdwc->shdwc_base = devm_ioremap_resource(&pdev->dev, res);
-       if (IS_ERR(at91_shdwc->shdwc_base)) {
-               dev_err(&pdev->dev, "Could not map reset controller address\n");
+       if (IS_ERR(at91_shdwc->shdwc_base))
                return PTR_ERR(at91_shdwc->shdwc_base);
-       }
 
        match = of_match_node(at91_shdwc_of_match, pdev->dev.of_node);
        at91_shdwc->rcfg = match->data;