]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
[media] i2c: Deletion of an unnecessary check before the function call "rc_unregister...
authorMarkus Elfring <elfring@users.sourceforge.net>
Thu, 20 Nov 2014 10:13:16 +0000 (07:13 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 25 Nov 2014 15:30:35 +0000 (13:30 -0200)
The rc_unregister_device() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/i2c/ir-kbd-i2c.c

index 8311f1a9a38e34a679d19c61e91900014a9e15e7..175a7611495357cb7117b58144363f4e1ad5f333 100644 (file)
@@ -464,8 +464,7 @@ static int ir_remove(struct i2c_client *client)
        cancel_delayed_work_sync(&ir->work);
 
        /* unregister device */
-       if (ir->rc)
-               rc_unregister_device(ir->rc);
+       rc_unregister_device(ir->rc);
 
        /* free memory */
        return 0;