]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
ASoC: fsl: fsl_esai: clarify expression
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 19 Feb 2021 23:29:32 +0000 (17:29 -0600)
committerMark Brown <broonie@kernel.org>
Wed, 10 Mar 2021 13:06:38 +0000 (13:06 +0000)
cppcheck warning:

sound/soc/fsl/fsl_esai.c:307:16: style: Clarify calculation precedence
for '%' and '?'. [clarifyCalculation]
    clk_id % 2 ? "extal" : "fsys");
               ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210219232937.6440-5-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/fsl/fsl_esai.c

index 08056fa0a0fa5ff1f5e18db91569224b7958b33f..41b154417b929f1cdea44bad41a9467b20fda896 100644 (file)
@@ -304,7 +304,7 @@ static int fsl_esai_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id,
 
        if (IS_ERR(clksrc)) {
                dev_err(dai->dev, "no assigned %s clock\n",
-                               clk_id % 2 ? "extal" : "fsys");
+                       (clk_id % 2) ? "extal" : "fsys");
                return PTR_ERR(clksrc);
        }
        clk_rate = clk_get_rate(clksrc);