]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commitdiff
Merge branch 'acpi-resources'
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 10 Feb 2015 15:05:16 +0000 (16:05 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 10 Feb 2015 15:05:16 +0000 (16:05 +0100)
* acpi-resources: (23 commits)
  Merge branch 'pci/host-generic' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci into acpi-resources
  x86/irq, ACPI: Implement ACPI driver to support IOAPIC hotplug
  ACPI: Add interfaces to parse IOAPIC ID for IOAPIC hotplug
  x86/PCI: Refine the way to release PCI IRQ resources
  x86/PCI/ACPI: Use common ACPI resource interfaces to simplify implementation
  x86/PCI: Fix the range check for IO resources
  PCI: Use common resource list management code instead of private implementation
  resources: Move struct resource_list_entry from ACPI into resource core
  ACPI: Introduce helper function acpi_dev_filter_resource_type()
  ACPI: Add field offset to struct resource_list_entry
  ACPI: Translate resource into master side address for bridge window resources
  ACPI: Return translation offset when parsing ACPI address space resources
  ACPI: Enforce stricter checks for address space descriptors
  ACPI: Set flag IORESOURCE_UNSET for unassigned resources
  ACPI: Normalize return value of resource parser functions
  ACPI: Fix a bug in parsing ACPI Memory24 resource
  ACPI: Add prefetch decoding to the address space parser
  ACPI: Move the window flag logic to the combined parser
  ACPI: Unify the parsing of address_space and ext_address_space
  ACPI: Let the parser return false for disabled resources
  ...

30 files changed:
arch/arm/kernel/bios32.c
arch/x86/include/asm/pci_x86.h
arch/x86/pci/acpi.c
arch/x86/pci/bus_numa.c
arch/x86/pci/common.c
arch/x86/pci/intel_mid_pci.c
arch/x86/pci/irq.c
drivers/acpi/Kconfig
drivers/acpi/Makefile
drivers/acpi/acpi_lpss.c
drivers/acpi/acpi_platform.c
drivers/acpi/internal.h
drivers/acpi/ioapic.c [new file with mode: 0644]
drivers/acpi/pci_irq.c
drivers/acpi/pci_root.c
drivers/acpi/processor_core.c
drivers/acpi/resource.c
drivers/dma/acpi-dma.c
drivers/of/of_pci.c
drivers/pci/bus.c
drivers/pci/host-bridge.c
drivers/pci/host/pci-host-generic.c
drivers/pci/host/pci-xgene.c
drivers/pci/host/pcie-xilinx.c
drivers/pci/probe.c
drivers/pnp/pnpacpi/rsparser.c
include/linux/acpi.h
include/linux/pci.h
include/linux/resource_ext.h [new file with mode: 0644]
kernel/resource.c

index a4effd6d8f2f52aa3f3c82c1b7b98d650d2263ab..016991792b0bd5c1e804d21e4e3cf781015a2166 100644 (file)
@@ -422,17 +422,16 @@ static int pcibios_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)
 static int pcibios_init_resources(int busnr, struct pci_sys_data *sys)
 {
        int ret;
-       struct pci_host_bridge_window *window;
+       struct resource_entry *window;
 
        if (list_empty(&sys->resources)) {
                pci_add_resource_offset(&sys->resources,
                         &iomem_resource, sys->mem_offset);
        }
 
-       list_for_each_entry(window, &sys->resources, list) {
+       resource_list_for_each_entry(window, &sys->resources)
                if (resource_type(window->res) == IORESOURCE_IO)
                        return 0;
-       }
 
        sys->io_res.start = (busnr * SZ_64K) ?  : pcibios_min_io;
        sys->io_res.end = (busnr + 1) * SZ_64K - 1;
index 164e3f8d3c3dbb6eb4fc0ea60e01cae15fe5116e..fa1195dae42541aaa1d836782a3a65aa25640e74 100644 (file)
@@ -93,8 +93,6 @@ extern raw_spinlock_t pci_config_lock;
 extern int (*pcibios_enable_irq)(struct pci_dev *dev);
 extern void (*pcibios_disable_irq)(struct pci_dev *dev);
 
-extern bool mp_should_keep_irq(struct device *dev);
-
 struct pci_raw_ops {
        int (*read)(unsigned int domain, unsigned int bus, unsigned int devfn,
                                                int reg, int len, u32 *val);
index bb98afd0591e7766cf2729065139f3251a60409a..6ac273832f284635ac1a66bf3f8551de379fa0f0 100644 (file)
@@ -10,9 +10,6 @@
 struct pci_root_info {
        struct acpi_device *bridge;
        char name[16];
-       unsigned int res_num;
-       struct resource *res;
-       resource_size_t *res_offset;
        struct pci_sysdata sd;
 #ifdef CONFIG_PCI_MMCONFIG
        bool mcfg_added;
@@ -218,130 +215,41 @@ static void teardown_mcfg_map(struct pci_root_info *info)
 }
 #endif
 
-static acpi_status resource_to_addr(struct acpi_resource *resource,
-                                   struct acpi_resource_address64 *addr)
-{
-       acpi_status status;
-       struct acpi_resource_memory24 *memory24;
-       struct acpi_resource_memory32 *memory32;
-       struct acpi_resource_fixed_memory32 *fixed_memory32;
-
-       memset(addr, 0, sizeof(*addr));
-       switch (resource->type) {
-       case ACPI_RESOURCE_TYPE_MEMORY24:
-               memory24 = &resource->data.memory24;
-               addr->resource_type = ACPI_MEMORY_RANGE;
-               addr->address.minimum = memory24->minimum;
-               addr->address.address_length = memory24->address_length;
-               addr->address.maximum = addr->address.minimum + addr->address.address_length - 1;
-               return AE_OK;
-       case ACPI_RESOURCE_TYPE_MEMORY32:
-               memory32 = &resource->data.memory32;
-               addr->resource_type = ACPI_MEMORY_RANGE;
-               addr->address.minimum = memory32->minimum;
-               addr->address.address_length = memory32->address_length;
-               addr->address.maximum = addr->address.minimum + addr->address.address_length - 1;
-               return AE_OK;
-       case ACPI_RESOURCE_TYPE_FIXED_MEMORY32:
-               fixed_memory32 = &resource->data.fixed_memory32;
-               addr->resource_type = ACPI_MEMORY_RANGE;
-               addr->address.minimum = fixed_memory32->address;
-               addr->address.address_length = fixed_memory32->address_length;
-               addr->address.maximum = addr->address.minimum + addr->address.address_length - 1;
-               return AE_OK;
-       case ACPI_RESOURCE_TYPE_ADDRESS16:
-       case ACPI_RESOURCE_TYPE_ADDRESS32:
-       case ACPI_RESOURCE_TYPE_ADDRESS64:
-               status = acpi_resource_to_address64(resource, addr);
-               if (ACPI_SUCCESS(status) &&
-                   (addr->resource_type == ACPI_MEMORY_RANGE ||
-                   addr->resource_type == ACPI_IO_RANGE) &&
-                   addr->address.address_length > 0) {
-                       return AE_OK;
-               }
-               break;
-       }
-       return AE_ERROR;
-}
-
-static acpi_status count_resource(struct acpi_resource *acpi_res, void *data)
+static void validate_resources(struct device *dev, struct list_head *crs_res,
+                              unsigned long type)
 {
-       struct pci_root_info *info = data;
-       struct acpi_resource_address64 addr;
-       acpi_status status;
-
-       status = resource_to_addr(acpi_res, &addr);
-       if (ACPI_SUCCESS(status))
-               info->res_num++;
-       return AE_OK;
-}
-
-static acpi_status setup_resource(struct acpi_resource *acpi_res, void *data)
-{
-       struct pci_root_info *info = data;
-       struct resource *res;
-       struct acpi_resource_address64 addr;
-       acpi_status status;
-       unsigned long flags;
-       u64 start, orig_end, end;
-
-       status = resource_to_addr(acpi_res, &addr);
-       if (!ACPI_SUCCESS(status))
-               return AE_OK;
-
-       if (addr.resource_type == ACPI_MEMORY_RANGE) {
-               flags = IORESOURCE_MEM;
-               if (addr.info.mem.caching == ACPI_PREFETCHABLE_MEMORY)
-                       flags |= IORESOURCE_PREFETCH;
-       } else if (addr.resource_type == ACPI_IO_RANGE) {
-               flags = IORESOURCE_IO;
-       } else
-               return AE_OK;
-
-       start = addr.address.minimum + addr.address.translation_offset;
-       orig_end = end = addr.address.maximum + addr.address.translation_offset;
-
-       /* Exclude non-addressable range or non-addressable portion of range */
-       end = min(end, (u64)iomem_resource.end);
-       if (end <= start) {
-               dev_info(&info->bridge->dev,
-                       "host bridge window [%#llx-%#llx] "
-                       "(ignored, not CPU addressable)\n", start, orig_end);
-               return AE_OK;
-       } else if (orig_end != end) {
-               dev_info(&info->bridge->dev,
-                       "host bridge window [%#llx-%#llx] "
-                       "([%#llx-%#llx] ignored, not CPU addressable)\n", 
-                       start, orig_end, end + 1, orig_end);
-       }
+       LIST_HEAD(list);
+       struct resource *res1, *res2, *root = NULL;
+       struct resource_entry *tmp, *entry, *entry2;
 
-       res = &info->res[info->res_num];
-       res->name = info->name;
-       res->flags = flags;
-       res->start = start;
-       res->end = end;
-       info->res_offset[info->res_num] = addr.address.translation_offset;
-       info->res_num++;
+       BUG_ON((type & (IORESOURCE_MEM | IORESOURCE_IO)) == 0);
+       root = (type & IORESOURCE_MEM) ? &iomem_resource : &ioport_resource;
 
-       if (!pci_use_crs)
-               dev_printk(KERN_DEBUG, &info->bridge->dev,
-                          "host bridge window %pR (ignored)\n", res);
+       list_splice_init(crs_res, &list);
+       resource_list_for_each_entry_safe(entry, tmp, &list) {
+               bool free = false;
+               resource_size_t end;
 
-       return AE_OK;
-}
-
-static void coalesce_windows(struct pci_root_info *info, unsigned long type)
-{
-       int i, j;
-       struct resource *res1, *res2;
-
-       for (i = 0; i < info->res_num; i++) {
-               res1 = &info->res[i];
+               res1 = entry->res;
                if (!(res1->flags & type))
-                       continue;
+                       goto next;
+
+               /* Exclude non-addressable range or non-addressable portion */
+               end = min(res1->end, root->end);
+               if (end <= res1->start) {
+                       dev_info(dev, "host bridge window %pR (ignored, not CPU addressable)\n",
+                                res1);
+                       free = true;
+                       goto next;
+               } else if (res1->end != end) {
+                       dev_info(dev, "host bridge window %pR ([%#llx-%#llx] ignored, not CPU addressable)\n",
+                                res1, (unsigned long long)end + 1,
+                                (unsigned long long)res1->end);
+                       res1->end = end;
+               }
 
-               for (j = i + 1; j < info->res_num; j++) {
-                       res2 = &info->res[j];
+               resource_list_for_each_entry(entry2, crs_res) {
+                       res2 = entry2->res;
                        if (!(res2->flags & type))
                                continue;
 
@@ -353,118 +261,92 @@ static void coalesce_windows(struct pci_root_info *info, unsigned long type)
                        if (resource_overlaps(res1, res2)) {
                                res2->start = min(res1->start, res2->start);
                                res2->end = max(res1->end, res2->end);
-                               dev_info(&info->bridge->dev,
-                                        "host bridge window expanded to %pR; %pR ignored\n",
+                               dev_info(dev, "host bridge window expanded to %pR; %pR ignored\n",
                                         res2, res1);
-                               res1->flags = 0;
+                               free = true;
+                               goto next;
                        }
                }
+
+next:
+               resource_list_del(entry);
+               if (free)
+                       resource_list_free_entry(entry);
+               else
+                       resource_list_add_tail(entry, crs_res);
        }
 }
 
 static void add_resources(struct pci_root_info *info,
-                         struct list_head *resources)
+                         struct list_head *resources,
+                         struct list_head *crs_res)
 {
-       int i;
-       struct resource *res, *root, *conflict;
-
-       coalesce_windows(info, IORESOURCE_MEM);
-       coalesce_windows(info, IORESOURCE_IO);
+       struct resource_entry *entry, *tmp;
+       struct resource *res, *conflict, *root = NULL;
 
-       for (i = 0; i < info->res_num; i++) {
-               res = &info->res[i];
+       validate_resources(&info->bridge->dev, crs_res, IORESOURCE_MEM);
+       validate_resources(&info->bridge->dev, crs_res, IORESOURCE_IO);
 
+       resource_list_for_each_entry_safe(entry, tmp, crs_res) {
+               res = entry->res;
                if (res->flags & IORESOURCE_MEM)
                        root = &iomem_resource;
                else if (res->flags & IORESOURCE_IO)
                        root = &ioport_resource;
                else
-                       continue;
+                       BUG_ON(res);
 
                conflict = insert_resource_conflict(root, res);
-               if (conflict)
+               if (conflict) {
                        dev_info(&info->bridge->dev,
                                 "ignoring host bridge window %pR (conflicts with %s %pR)\n",
                                 res, conflict->name, conflict);
-               else
-                       pci_add_resource_offset(resources, res,
-                                       info->res_offset[i]);
+                       resource_list_destroy_entry(entry);
+               }
        }
-}
 
-static void free_pci_root_info_res(struct pci_root_info *info)
-{
-       kfree(info->res);
-       info->res = NULL;
-       kfree(info->res_offset);
-       info->res_offset = NULL;
-       info->res_num = 0;
+       list_splice_tail(crs_res, resources);
 }
 
-static void __release_pci_root_info(struct pci_root_info *info)
+static void release_pci_root_info(struct pci_host_bridge *bridge)
 {
-       int i;
        struct resource *res;
+       struct resource_entry *entry;
+       struct pci_root_info *info = bridge->release_data;
 
-       for (i = 0; i < info->res_num; i++) {
-               res = &info->res[i];
-
-               if (!res->parent)
-                       continue;
-
-               if (!(res->flags & (IORESOURCE_MEM | IORESOURCE_IO)))
-                       continue;
-
-               release_resource(res);
+       resource_list_for_each_entry(entry, &bridge->windows) {
+               res = entry->res;
+               if (res->parent &&
+                   (res->flags & (IORESOURCE_MEM | IORESOURCE_IO)))
+                       release_resource(res);
        }
 
-       free_pci_root_info_res(info);
-
        teardown_mcfg_map(info);
-
        kfree(info);
 }
 
-static void release_pci_root_info(struct pci_host_bridge *bridge)
-{
-       struct pci_root_info *info = bridge->release_data;
-
-       __release_pci_root_info(info);
-}
-
 static void probe_pci_root_info(struct pci_root_info *info,
                                struct acpi_device *device,
-                               int busnum, int domain)
+                               int busnum, int domain,
+                               struct list_head *list)
 {
-       size_t size;
+       int ret;
+       struct resource_entry *entry;
 
        sprintf(info->name, "PCI Bus %04x:%02x", domain, busnum);
        info->bridge = device;
-
-       info->res_num = 0;
-       acpi_walk_resources(device->handle, METHOD_NAME__CRS, count_resource,
-                               info);
-       if (!info->res_num)
-               return;
-
-       size = sizeof(*info->res) * info->res_num;
-       info->res = kzalloc_node(size, GFP_KERNEL, info->sd.node);
-       if (!info->res) {
-               info->res_num = 0;
-               return;
-       }
-
-       size = sizeof(*info->res_offset) * info->res_num;
-       info->res_num = 0;
-       info->res_offset = kzalloc_node(size, GFP_KERNEL, info->sd.node);
-       if (!info->res_offset) {
-               kfree(info->res);
-               info->res = NULL;
-               return;
-       }
-
-       acpi_walk_resources(device->handle, METHOD_NAME__CRS, setup_resource,
-                               info);
+       ret = acpi_dev_get_resources(device, list,
+                                    acpi_dev_filter_resource_type_cb,
+                                    (void *)(IORESOURCE_IO | IORESOURCE_MEM));
+       if (ret < 0)
+               dev_warn(&device->dev,
+                        "failed to parse _CRS method, error code %d\n", ret);
+       else if (ret == 0)
+               dev_dbg(&device->dev,
+                       "no IO and memory resources present in _CRS\n");
+       else
+               resource_list_for_each_entry(entry, list)
+                       entry->res->name = info->name;
 }
 
 struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root *root)
@@ -473,6 +355,8 @@ struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root *root)
        struct pci_root_info *info;
        int domain = root->segment;
        int busnum = root->secondary.start;
+       struct resource_entry *res_entry;
+       LIST_HEAD(crs_res);
        LIST_HEAD(resources);
        struct pci_bus *bus;
        struct pci_sysdata *sd;
@@ -520,18 +404,22 @@ struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root *root)
                memcpy(bus->sysdata, sd, sizeof(*sd));
                kfree(info);
        } else {
-               probe_pci_root_info(info, device, busnum, domain);
-
                /* insert busn res at first */
                pci_add_resource(&resources,  &root->secondary);
+
                /*
                 * _CRS with no apertures is normal, so only fall back to
                 * defaults or native bridge info if we're ignoring _CRS.
                 */
-               if (pci_use_crs)
-                       add_resources(info, &resources);
-               else {
-                       free_pci_root_info_res(info);
+               probe_pci_root_info(info, device, busnum, domain, &crs_res);
+               if (pci_use_crs) {
+                       add_resources(info, &resources, &crs_res);
+               } else {
+                       resource_list_for_each_entry(res_entry, &crs_res)
+                               dev_printk(KERN_DEBUG, &device->dev,
+                                          "host bridge window %pR (ignored)\n",
+                                          res_entry->res);
+                       resource_list_free(&crs_res);
                        x86_pci_root_bus_resources(busnum, &resources);
                }
 
@@ -546,8 +434,9 @@ struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root *root)
                                to_pci_host_bridge(bus->bridge),
                                release_pci_root_info, info);
                } else {
-                       pci_free_resource_list(&resources);
-                       __release_pci_root_info(info);
+                       resource_list_free(&resources);
+                       teardown_mcfg_map(info);
+                       kfree(info);
                }
        }
 
index f3a2cfc14125bbb387d7eae474304a59cf8b2ef1..7bcf06a7cd12069e9e4f5c2f13066e1551ba8a27 100644 (file)
@@ -31,7 +31,7 @@ void x86_pci_root_bus_resources(int bus, struct list_head *resources)
 {
        struct pci_root_info *info = x86_find_pci_root_info(bus);
        struct pci_root_res *root_res;
-       struct pci_host_bridge_window *window;
+       struct resource_entry *window;
        bool found = false;
 
        if (!info)
@@ -41,7 +41,7 @@ void x86_pci_root_bus_resources(int bus, struct list_head *resources)
               bus);
 
        /* already added by acpi ? */
-       list_for_each_entry(window, resources, list)
+       resource_list_for_each_entry(window, resources)
                if (window->res->flags & IORESOURCE_BUS) {
                        found = true;
                        break;
index 2fb384724ebb52d1cf0ba6131b418e81609ca55c..3d2612b68694efd294ca214d478c7777030f4b03 100644 (file)
@@ -513,6 +513,31 @@ void __init pcibios_set_cache_line_size(void)
        }
 }
 
+/*
+ * Some device drivers assume dev->irq won't change after calling
+ * pci_disable_device(). So delay releasing of IRQ resource to driver
+ * unbinding time. Otherwise it will break PM subsystem and drivers
+ * like xen-pciback etc.
+ */
+static int pci_irq_notifier(struct notifier_block *nb, unsigned long action,
+                           void *data)
+{
+       struct pci_dev *dev = to_pci_dev(data);
+
+       if (action != BUS_NOTIFY_UNBOUND_DRIVER)
+               return NOTIFY_DONE;
+
+       if (pcibios_disable_irq)
+               pcibios_disable_irq(dev);
+
+       return NOTIFY_OK;
+}
+
+static struct notifier_block pci_irq_nb = {
+       .notifier_call = pci_irq_notifier,
+       .priority = INT_MIN,
+};
+
 int __init pcibios_init(void)
 {
        if (!raw_pci_ops) {
@@ -525,6 +550,9 @@ int __init pcibios_init(void)
 
        if (pci_bf_sort >= pci_force_bf)
                pci_sort_breadthfirst();
+
+       bus_register_notifier(&pci_bus_type, &pci_irq_nb);
+
        return 0;
 }
 
@@ -683,12 +711,6 @@ int pcibios_enable_device(struct pci_dev *dev, int mask)
        return 0;
 }
 
-void pcibios_disable_device (struct pci_dev *dev)
-{
-       if (!pci_dev_msi_enabled(dev) && pcibios_disable_irq)
-               pcibios_disable_irq(dev);
-}
-
 int pci_ext_cfg_avail(void)
 {
        if (raw_pci_ext_ops)
index 44b9271580b5b0532bddf121af554cc0ec951779..95c2471f6819d9759a8c73ad2ea1d166581c6fb7 100644 (file)
@@ -234,10 +234,10 @@ static int intel_mid_pci_irq_enable(struct pci_dev *dev)
 
 static void intel_mid_pci_irq_disable(struct pci_dev *dev)
 {
-       if (!mp_should_keep_irq(&dev->dev) && dev->irq_managed &&
-           dev->irq > 0) {
+       if (dev->irq_managed && dev->irq > 0) {
                mp_unmap_irq(dev->irq);
                dev->irq_managed = 0;
+               dev->irq = 0;
        }
 }
 
index 5dc6ca5e174131d2c7208ea1ed86739ef4532d22..e71b3dbd87b8f688d3f2cbfa995421bd516ba581 100644 (file)
@@ -1256,22 +1256,9 @@ static int pirq_enable_irq(struct pci_dev *dev)
        return 0;
 }
 
-bool mp_should_keep_irq(struct device *dev)
-{
-       if (dev->power.is_prepared)
-               return true;
-#ifdef CONFIG_PM
-       if (dev->power.runtime_status == RPM_SUSPENDING)
-               return true;
-#endif
-
-       return false;
-}
-
 static void pirq_disable_irq(struct pci_dev *dev)
 {
-       if (io_apic_assign_pci_irqs && !mp_should_keep_irq(&dev->dev) &&
-           dev->irq_managed && dev->irq) {
+       if (io_apic_assign_pci_irqs && dev->irq_managed && dev->irq) {
                mp_unmap_irq(dev->irq);
                dev->irq = 0;
                dev->irq_managed = 0;
index 8951cefb0a965834be5a814a2a23e15ce7177c72..e6c3ddd926658cd615241328e1f51b90ce16c611 100644 (file)
@@ -315,6 +315,12 @@ config ACPI_HOTPLUG_MEMORY
          To compile this driver as a module, choose M here:
          the module will be called acpi_memhotplug.
 
+config ACPI_HOTPLUG_IOAPIC
+       bool
+       depends on PCI
+       depends on X86_IO_APIC
+       default y
+
 config ACPI_SBS
        tristate "Smart Battery System"
        depends on X86
index 0071141b6bbc8510e1132e5d98982c84a8cb8066..b18cd2151ddb244e1961c48165ab973d88880d71 100644 (file)
@@ -70,6 +70,7 @@ obj-$(CONFIG_ACPI_PROCESSOR)  += processor.o
 obj-y                          += container.o
 obj-$(CONFIG_ACPI_THERMAL)     += thermal.o
 obj-y                          += acpi_memhotplug.o
+obj-$(CONFIG_ACPI_HOTPLUG_IOAPIC) += ioapic.o
 obj-$(CONFIG_ACPI_BATTERY)     += battery.o
 obj-$(CONFIG_ACPI_SBS)         += sbshc.o
 obj-$(CONFIG_ACPI_SBS)         += sbs.o
index 08fbff507dc40a660293afb07263c7e9a2ab487c..02e835f3cf8aa76326b9994768b75f2d39c39fed 100644 (file)
@@ -307,7 +307,7 @@ static int acpi_lpss_create_device(struct acpi_device *adev,
 {
        struct lpss_device_desc *dev_desc;
        struct lpss_private_data *pdata;
-       struct resource_list_entry *rentry;
+       struct resource_entry *rentry;
        struct list_head resource_list;
        struct platform_device *pdev;
        int ret;
@@ -327,12 +327,12 @@ static int acpi_lpss_create_device(struct acpi_device *adev,
                goto err_out;
 
        list_for_each_entry(rentry, &resource_list, node)
-               if (resource_type(&rentry->res) == IORESOURCE_MEM) {
+               if (resource_type(rentry->res) == IORESOURCE_MEM) {
                        if (dev_desc->prv_size_override)
                                pdata->mmio_size = dev_desc->prv_size_override;
                        else
-                               pdata->mmio_size = resource_size(&rentry->res);
-                       pdata->mmio_base = ioremap(rentry->res.start,
+                               pdata->mmio_size = resource_size(rentry->res);
+                       pdata->mmio_base = ioremap(rentry->res->start,
                                                   pdata->mmio_size);
                        if (!pdata->mmio_base)
                                goto err_out;
index 6ba8beb6b9d2a515828c3987393dc75fa8b6bc2c..1284138e42ab486d584f61e3f90bbaf0320a1a5b 100644 (file)
@@ -45,7 +45,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev)
        struct platform_device *pdev = NULL;
        struct acpi_device *acpi_parent;
        struct platform_device_info pdevinfo;
-       struct resource_list_entry *rentry;
+       struct resource_entry *rentry;
        struct list_head resource_list;
        struct resource *resources = NULL;
        int count;
@@ -71,7 +71,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev)
                }
                count = 0;
                list_for_each_entry(rentry, &resource_list, node)
-                       resources[count++] = rentry->res;
+                       resources[count++] = *rentry->res;
 
                acpi_dev_free_resource_list(&resource_list);
        }
index 81ae69fde7d5c17bcc171e0c754e355e1680af8e..56b321aa2b1c8a3b4395623ead294bc967702cf8 100644 (file)
@@ -35,6 +35,13 @@ void acpi_int340x_thermal_init(void);
 int acpi_sysfs_init(void);
 void acpi_container_init(void);
 void acpi_memory_hotplug_init(void);
+#ifdef CONFIG_ACPI_HOTPLUG_IOAPIC
+int acpi_ioapic_add(struct acpi_pci_root *root);
+int acpi_ioapic_remove(struct acpi_pci_root *root);
+#else
+static inline int acpi_ioapic_add(struct acpi_pci_root *root) { return 0; }
+static inline int acpi_ioapic_remove(struct acpi_pci_root *root) { return 0; }
+#endif
 #ifdef CONFIG_ACPI_DOCK
 void register_dock_dependent_device(struct acpi_device *adev,
                                    acpi_handle dshandle);
diff --git a/drivers/acpi/ioapic.c b/drivers/acpi/ioapic.c
new file mode 100644 (file)
index 0000000..ccdc8db
--- /dev/null
@@ -0,0 +1,229 @@
+/*
+ * IOAPIC/IOxAPIC/IOSAPIC driver
+ *
+ * Copyright (C) 2009 Fujitsu Limited.
+ * (c) Copyright 2009 Hewlett-Packard Development Company, L.P.
+ *
+ * Copyright (C) 2014 Intel Corporation
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * Based on original drivers/pci/ioapic.c
+ *     Yinghai Lu <yinghai@kernel.org>
+ *     Jiang Liu <jiang.liu@intel.com>
+ */
+
+/*
+ * This driver manages I/O APICs added by hotplug after boot.
+ * We try to claim all I/O APIC devices, but those present at boot were
+ * registered when we parsed the ACPI MADT.
+ */
+
+#define pr_fmt(fmt) "ACPI : IOAPIC: " fmt
+
+#include <linux/slab.h>
+#include <linux/acpi.h>
+#include <linux/pci.h>
+#include <acpi/acpi.h>
+
+struct acpi_pci_ioapic {
+       acpi_handle     root_handle;
+       acpi_handle     handle;
+       u32             gsi_base;
+       struct resource res;
+       struct pci_dev  *pdev;
+       struct list_head list;
+};
+
+static LIST_HEAD(ioapic_list);
+static DEFINE_MUTEX(ioapic_list_lock);
+
+static acpi_status setup_res(struct acpi_resource *acpi_res, void *data)
+{
+       struct resource *res = data;
+       struct resource_win win;
+
+       res->flags = 0;
+       if (acpi_dev_filter_resource_type(acpi_res, IORESOURCE_MEM) == 0)
+               return AE_OK;
+
+       if (!acpi_dev_resource_memory(acpi_res, res)) {
+               if (acpi_dev_resource_address_space(acpi_res, &win) ||
+                   acpi_dev_resource_ext_address_space(acpi_res, &win))
+                       *res = win.res;
+       }
+       if ((res->flags & IORESOURCE_PREFETCH) ||
+           (res->flags & IORESOURCE_DISABLED))
+               res->flags = 0;
+
+       return AE_CTRL_TERMINATE;
+}
+
+static bool acpi_is_ioapic(acpi_handle handle, char **type)
+{
+       acpi_status status;
+       struct acpi_device_info *info;
+       char *hid = NULL;
+       bool match = false;
+
+       if (!acpi_has_method(handle, "_GSB"))
+               return false;
+
+       status = acpi_get_object_info(handle, &info);
+       if (ACPI_SUCCESS(status)) {
+               if (info->valid & ACPI_VALID_HID)
+                       hid = info->hardware_id.string;
+               if (hid) {
+                       if (strcmp(hid, "ACPI0009") == 0) {
+                               *type = "IOxAPIC";
+                               match = true;
+                       } else if (strcmp(hid, "ACPI000A") == 0) {
+                               *type = "IOAPIC";
+                               match = true;
+                       }
+               }
+               kfree(info);
+       }
+
+       return match;
+}
+
+static acpi_status handle_ioapic_add(acpi_handle handle, u32 lvl,
+                                    void *context, void **rv)
+{
+       acpi_status status;
+       unsigned long long gsi_base;
+       struct acpi_pci_ioapic *ioapic;
+       struct pci_dev *dev = NULL;
+       struct resource *res = NULL;
+       char *type = NULL;
+
+       if (!acpi_is_ioapic(handle, &type))
+               return AE_OK;
+
+       mutex_lock(&ioapic_list_lock);
+       list_for_each_entry(ioapic, &ioapic_list, list)
+               if (ioapic->handle == handle) {
+                       mutex_unlock(&ioapic_list_lock);
+                       return AE_OK;
+               }
+
+       status = acpi_evaluate_integer(handle, "_GSB", NULL, &gsi_base);
+       if (ACPI_FAILURE(status)) {
+               acpi_handle_warn(handle, "failed to evaluate _GSB method\n");
+               goto exit;
+       }
+
+       ioapic = kzalloc(sizeof(*ioapic), GFP_KERNEL);
+       if (!ioapic) {
+               pr_err("cannot allocate memory for new IOAPIC\n");
+               goto exit;
+       } else {
+               ioapic->root_handle = (acpi_handle)context;
+               ioapic->handle = handle;
+               ioapic->gsi_base = (u32)gsi_base;
+               INIT_LIST_HEAD(&ioapic->list);
+       }
+
+       if (acpi_ioapic_registered(handle, (u32)gsi_base))
+               goto done;
+
+       dev = acpi_get_pci_dev(handle);
+       if (dev && pci_resource_len(dev, 0)) {
+               if (pci_enable_device(dev) < 0)
+                       goto exit_put;
+               pci_set_master(dev);
+               if (pci_request_region(dev, 0, type))
+                       goto exit_disable;
+               res = &dev->resource[0];
+               ioapic->pdev = dev;
+       } else {
+               pci_dev_put(dev);
+               dev = NULL;
+
+               res = &ioapic->res;
+               acpi_walk_resources(handle, METHOD_NAME__CRS, setup_res, res);
+               if (res->flags == 0) {
+                       acpi_handle_warn(handle, "failed to get resource\n");
+                       goto exit_free;
+               } else if (request_resource(&iomem_resource, res)) {
+                       acpi_handle_warn(handle, "failed to insert resource\n");
+                       goto exit_free;
+               }
+       }
+
+       if (acpi_register_ioapic(handle, res->start, (u32)gsi_base)) {
+               acpi_handle_warn(handle, "failed to register IOAPIC\n");
+               goto exit_release;
+       }
+done:
+       list_add(&ioapic->list, &ioapic_list);
+       mutex_unlock(&ioapic_list_lock);
+
+       if (dev)
+               dev_info(&dev->dev, "%s at %pR, GSI %u\n",
+                        type, res, (u32)gsi_base);
+       else
+               acpi_handle_info(handle, "%s at %pR, GSI %u\n",
+                                type, res, (u32)gsi_base);
+
+       return AE_OK;
+
+exit_release:
+       if (dev)
+               pci_release_region(dev, 0);
+       else
+               release_resource(res);
+exit_disable:
+       if (dev)
+               pci_disable_device(dev);
+exit_put:
+       pci_dev_put(dev);
+exit_free:
+       kfree(ioapic);
+exit:
+       mutex_unlock(&ioapic_list_lock);
+       *(acpi_status *)rv = AE_ERROR;
+       return AE_OK;
+}
+
+int acpi_ioapic_add(struct acpi_pci_root *root)
+{
+       acpi_status status, retval = AE_OK;
+
+       status = acpi_walk_namespace(ACPI_TYPE_DEVICE, root->device->handle,
+                                    UINT_MAX, handle_ioapic_add, NULL,
+                                    root->device->handle, (void **)&retval);
+
+       return ACPI_SUCCESS(status) && ACPI_SUCCESS(retval) ? 0 : -ENODEV;
+}
+
+int acpi_ioapic_remove(struct acpi_pci_root *root)
+{
+       int retval = 0;
+       struct acpi_pci_ioapic *ioapic, *tmp;
+
+       mutex_lock(&ioapic_list_lock);
+       list_for_each_entry_safe(ioapic, tmp, &ioapic_list, list) {
+               if (root->device->handle != ioapic->root_handle)
+                       continue;
+
+               if (acpi_unregister_ioapic(ioapic->handle, ioapic->gsi_base))
+                       retval = -EBUSY;
+
+               if (ioapic->pdev) {
+                       pci_release_region(ioapic->pdev, 0);
+                       pci_disable_device(ioapic->pdev);
+                       pci_dev_put(ioapic->pdev);
+               } else if (ioapic->res.flags && ioapic->res.parent) {
+                       release_resource(&ioapic->res);
+               }
+               list_del(&ioapic->list);
+               kfree(ioapic);
+       }
+       mutex_unlock(&ioapic_list_lock);
+
+       return retval;
+}
index b1def411c0b89cbf7847b767063c5c2ab528e8a8..e7f718d6918a6a29b775aa97f7a40dc654d47136 100644 (file)
@@ -485,14 +485,6 @@ void acpi_pci_irq_disable(struct pci_dev *dev)
        if (!pin || !dev->irq_managed || dev->irq <= 0)
                return;
 
-       /* Keep IOAPIC pin configuration when suspending */
-       if (dev->dev.power.is_prepared)
-               return;
-#ifdef CONFIG_PM
-       if (dev->dev.power.runtime_status == RPM_SUSPENDING)
-               return;
-#endif
-
        entry = acpi_pci_irq_lookup(dev, pin);
        if (!entry)
                return;
@@ -513,5 +505,6 @@ void acpi_pci_irq_disable(struct pci_dev *dev)
        if (gsi >= 0) {
                acpi_unregister_gsi(gsi);
                dev->irq_managed = 0;
+               dev->irq = 0;
        }
 }
index e53e0f6592045516b8af9165f238986772e3bc96..68a5f712cd198e5cd61b866d2068b9d52a1274f4 100644 (file)
@@ -621,6 +621,7 @@ static int acpi_pci_root_add(struct acpi_device *device,
        if (hotadd) {
                pcibios_resource_survey_bus(root->bus);
                pci_assign_unassigned_root_bus_resources(root->bus);
+               acpi_ioapic_add(root);
        }
 
        pci_lock_rescan_remove();
@@ -644,6 +645,8 @@ static void acpi_pci_root_remove(struct acpi_device *device)
 
        pci_stop_root_bus(root->bus);
 
+       WARN_ON(acpi_ioapic_remove(root));
+
        device_set_run_wake(root->bus->bridge, false);
        pci_acpi_remove_bus_pm_notifier(device);
 
index 02e48394276c785aa84c72fcacf231b4b6cc4587..7962651cdbd43a6a7b7e22e75263f90c9567dc80 100644 (file)
@@ -4,6 +4,10 @@
  *
  *     Alex Chiang <achiang@hp.com>
  *     - Unified x86/ia64 implementations
+ *
+ * I/O APIC hotplug support
+ *     Yinghai Lu <yinghai@kernel.org>
+ *     Jiang Liu <jiang.liu@intel.com>
  */
 #include <linux/export.h>
 #include <linux/acpi.h>
 #define _COMPONENT             ACPI_PROCESSOR_COMPONENT
 ACPI_MODULE_NAME("processor_core");
 
+static struct acpi_table_madt *get_madt_table(void)
+{
+       static struct acpi_table_madt *madt;
+       static int read_madt;
+
+       if (!read_madt) {
+               if (ACPI_FAILURE(acpi_get_table(ACPI_SIG_MADT, 0,
+                                       (struct acpi_table_header **)&madt)))
+                       madt = NULL;
+               read_madt++;
+       }
+
+       return madt;
+}
+
 static int map_lapic_id(struct acpi_subtable_header *entry,
                 u32 acpi_id, int *apic_id)
 {
@@ -67,17 +86,10 @@ static int map_lsapic_id(struct acpi_subtable_header *entry,
 static int map_madt_entry(int type, u32 acpi_id)
 {
        unsigned long madt_end, entry;
-       static struct acpi_table_madt *madt;
-       static int read_madt;
        int phys_id = -1;       /* CPU hardware ID */
+       struct acpi_table_madt *madt;
 
-       if (!read_madt) {
-               if (ACPI_FAILURE(acpi_get_table(ACPI_SIG_MADT, 0,
-                                       (struct acpi_table_header **)&madt)))
-                       madt = NULL;
-               read_madt++;
-       }
-
+       madt = get_madt_table();
        if (!madt)
                return phys_id;
 
@@ -203,3 +215,96 @@ int acpi_get_cpuid(acpi_handle handle, int type, u32 acpi_id)
        return acpi_map_cpuid(phys_id, acpi_id);
 }
 EXPORT_SYMBOL_GPL(acpi_get_cpuid);
+
+#ifdef CONFIG_ACPI_HOTPLUG_IOAPIC
+static int get_ioapic_id(struct acpi_subtable_header *entry, u32 gsi_base,
+                        u64 *phys_addr, int *ioapic_id)
+{
+       struct acpi_madt_io_apic *ioapic = (struct acpi_madt_io_apic *)entry;
+
+       if (ioapic->global_irq_base != gsi_base)
+               return 0;
+
+       *phys_addr = ioapic->address;
+       *ioapic_id = ioapic->id;
+       return 1;
+}
+
+static int parse_madt_ioapic_entry(u32 gsi_base, u64 *phys_addr)
+{
+       struct acpi_subtable_header *hdr;
+       unsigned long madt_end, entry;
+       struct acpi_table_madt *madt;
+       int apic_id = -1;
+
+       madt = get_madt_table();
+       if (!madt)
+               return apic_id;
+
+       entry = (unsigned long)madt;
+       madt_end = entry + madt->header.length;
+
+       /* Parse all entries looking for a match. */
+       entry += sizeof(struct acpi_table_madt);
+       while (entry + sizeof(struct acpi_subtable_header) < madt_end) {
+               hdr = (struct acpi_subtable_header *)entry;
+               if (hdr->type == ACPI_MADT_TYPE_IO_APIC &&
+                   get_ioapic_id(hdr, gsi_base, phys_addr, &apic_id))
+                       break;
+               else
+                       entry += hdr->length;
+       }
+
+       return apic_id;
+}
+
+static int parse_mat_ioapic_entry(acpi_handle handle, u32 gsi_base,
+                                 u64 *phys_addr)
+{
+       struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
+       struct acpi_subtable_header *header;
+       union acpi_object *obj;
+       int apic_id = -1;
+
+       if (ACPI_FAILURE(acpi_evaluate_object(handle, "_MAT", NULL, &buffer)))
+               goto exit;
+
+       if (!buffer.length || !buffer.pointer)
+               goto exit;
+
+       obj = buffer.pointer;
+       if (obj->type != ACPI_TYPE_BUFFER ||
+           obj->buffer.length < sizeof(struct acpi_subtable_header))
+               goto exit;
+
+       header = (struct acpi_subtable_header *)obj->buffer.pointer;
+       if (header->type == ACPI_MADT_TYPE_IO_APIC)
+               get_ioapic_id(header, gsi_base, phys_addr, &apic_id);
+
+exit:
+       kfree(buffer.pointer);
+       return apic_id;
+}
+
+/**
+ * acpi_get_ioapic_id - Get IOAPIC ID and physical address matching @gsi_base
+ * @handle:    ACPI object for IOAPIC device
+ * @gsi_base:  GSI base to match with
+ * @phys_addr: Pointer to store physical address of matching IOAPIC record
+ *
+ * Walk resources returned by ACPI_MAT method, then ACPI MADT table, to search
+ * for an ACPI IOAPIC record matching @gsi_base.
+ * Return IOAPIC id and store physical address in @phys_addr if found a match,
+ * otherwise return <0.
+ */
+int acpi_get_ioapic_id(acpi_handle handle, u32 gsi_base, u64 *phys_addr)
+{
+       int apic_id;
+
+       apic_id = parse_mat_ioapic_entry(handle, gsi_base, phys_addr);
+       if (apic_id == -1)
+               apic_id = parse_madt_ioapic_entry(gsi_base, phys_addr);
+
+       return apic_id;
+}
+#endif /* CONFIG_ACPI_HOTPLUG_IOAPIC */
index d0a4d90c6bcc2c7f8841c022d677af56fa933a9a..4752b99399870efd068a1f1a6c656b1ebe333349 100644 (file)
 #define valid_IRQ(i) (true)
 #endif
 
-static unsigned long acpi_dev_memresource_flags(u64 len, u8 write_protect,
-                                               bool window)
+static bool acpi_dev_resource_len_valid(u64 start, u64 end, u64 len, bool io)
 {
-       unsigned long flags = IORESOURCE_MEM;
+       u64 reslen = end - start + 1;
 
-       if (len == 0)
-               flags |= IORESOURCE_DISABLED;
+       /*
+        * CHECKME: len might be required to check versus a minimum
+        * length as well. 1 for io is fine, but for memory it does
+        * not make any sense at all.
+        */
+       if (len && reslen && reslen == len && start <= end)
+               return true;
 
-       if (write_protect == ACPI_READ_WRITE_MEMORY)
-               flags |= IORESOURCE_MEM_WRITEABLE;
+       pr_info("ACPI: invalid or unassigned resource %s [%016llx - %016llx] length [%016llx]\n",
+               io ? "io" : "mem", start, end, len);
+
+       return false;
+}
+
+static void acpi_dev_memresource_flags(struct resource *res, u64 len,
+                                      u8 write_protect)
+{
+       res->flags = IORESOURCE_MEM;
 
-       if (window)
-               flags |= IORESOURCE_WINDOW;
+       if (!acpi_dev_resource_len_valid(res->start, res->end, len, false))
+               res->flags |= IORESOURCE_DISABLED | IORESOURCE_UNSET;
 
-       return flags;
+       if (write_protect == ACPI_READ_WRITE_MEMORY)
+               res->flags |= IORESOURCE_MEM_WRITEABLE;
 }
 
 static void acpi_dev_get_memresource(struct resource *res, u64 start, u64 len,
@@ -56,7 +69,7 @@ static void acpi_dev_get_memresource(struct resource *res, u64 start, u64 len,
 {
        res->start = start;
        res->end = start + len - 1;
-       res->flags = acpi_dev_memresource_flags(len, write_protect, false);
+       acpi_dev_memresource_flags(res, len, write_protect);
 }
 
 /**
@@ -67,6 +80,11 @@ static void acpi_dev_get_memresource(struct resource *res, u64 start, u64 len,
  * Check if the given ACPI resource object represents a memory resource and
  * if that's the case, use the information in it to populate the generic
  * resource object pointed to by @res.
+ *
+ * Return:
+ * 1) false with res->flags setting to zero: not the expected resource type
+ * 2) false with IORESOURCE_DISABLED in res->flags: valid unassigned resource
+ * 3) true: valid assigned resource
  */
 bool acpi_dev_resource_memory(struct acpi_resource *ares, struct resource *res)
 {
@@ -77,60 +95,52 @@ bool acpi_dev_resource_memory(struct acpi_resource *ares, struct resource *res)
        switch (ares->type) {
        case ACPI_RESOURCE_TYPE_MEMORY24:
                memory24 = &ares->data.memory24;
-               if (!memory24->minimum && !memory24->address_length)
-                       return false;
-               acpi_dev_get_memresource(res, memory24->minimum,
-                                        memory24->address_length,
+               acpi_dev_get_memresource(res, memory24->minimum << 8,
+                                        memory24->address_length << 8,
                                         memory24->write_protect);
                break;
        case ACPI_RESOURCE_TYPE_MEMORY32:
                memory32 = &ares->data.memory32;
-               if (!memory32->minimum && !memory32->address_length)
-                       return false;
                acpi_dev_get_memresource(res, memory32->minimum,
                                         memory32->address_length,
                                         memory32->write_protect);
                break;
        case ACPI_RESOURCE_TYPE_FIXED_MEMORY32:
                fixed_memory32 = &ares->data.fixed_memory32;
-               if (!fixed_memory32->address && !fixed_memory32->address_length)
-                       return false;
                acpi_dev_get_memresource(res, fixed_memory32->address,
                                         fixed_memory32->address_length,
                                         fixed_memory32->write_protect);
                break;
        default:
+               res->flags = 0;
                return false;
        }
-       return true;
+
+       return !(res->flags & IORESOURCE_DISABLED);
 }
 EXPORT_SYMBOL_GPL(acpi_dev_resource_memory);
 
-static unsigned int acpi_dev_ioresource_flags(u64 start, u64 end, u8 io_decode,
-                                             bool window)
+static void acpi_dev_ioresource_flags(struct resource *res, u64 len,
+                                     u8 io_decode)
 {
-       int flags = IORESOURCE_IO;
+       res->flags = IORESOURCE_IO;
 
-       if (io_decode == ACPI_DECODE_16)
-               flags |= IORESOURCE_IO_16BIT_ADDR;
+       if (!acpi_dev_resource_len_valid(res->start, res->end, len, true))
+               res->flags |= IORESOURCE_DISABLED | IORESOURCE_UNSET;
 
-       if (start > end || end >= 0x10003)
-               flags |= IORESOURCE_DISABLED;
+       if (res->end >= 0x10003)
+               res->flags |= IORESOURCE_DISABLED | IORESOURCE_UNSET;
 
-       if (window)
-               flags |= IORESOURCE_WINDOW;
-
-       return flags;
+       if (io_decode == ACPI_DECODE_16)
+               res->flags |= IORESOURCE_IO_16BIT_ADDR;
 }
 
 static void acpi_dev_get_ioresource(struct resource *res, u64 start, u64 len,
                                    u8 io_decode)
 {
-       u64 end = start + len - 1;
-
        res->start = start;
-       res->end = end;
-       res->flags = acpi_dev_ioresource_flags(start, end, io_decode, false);
+       res->end = start + len - 1;
+       acpi_dev_ioresource_flags(res, len, io_decode);
 }
 
 /**
@@ -141,6 +151,11 @@ static void acpi_dev_get_ioresource(struct resource *res, u64 start, u64 len,
  * Check if the given ACPI resource object represents an I/O resource and
  * if that's the case, use the information in it to populate the generic
  * resource object pointed to by @res.
+ *
+ * Return:
+ * 1) false with res->flags setting to zero: not the expected resource type
+ * 2) false with IORESOURCE_DISABLED in res->flags: valid unassigned resource
+ * 3) true: valid assigned resource
  */
 bool acpi_dev_resource_io(struct acpi_resource *ares, struct resource *res)
 {
@@ -150,135 +165,143 @@ bool acpi_dev_resource_io(struct acpi_resource *ares, struct resource *res)
        switch (ares->type) {
        case ACPI_RESOURCE_TYPE_IO:
                io = &ares->data.io;
-               if (!io->minimum && !io->address_length)
-                       return false;
                acpi_dev_get_ioresource(res, io->minimum,
                                        io->address_length,
                                        io->io_decode);
                break;
        case ACPI_RESOURCE_TYPE_FIXED_IO:
                fixed_io = &ares->data.fixed_io;
-               if (!fixed_io->address && !fixed_io->address_length)
-                       return false;
                acpi_dev_get_ioresource(res, fixed_io->address,
                                        fixed_io->address_length,
                                        ACPI_DECODE_10);
                break;
        default:
+               res->flags = 0;
                return false;
        }
-       return true;
+
+       return !(res->flags & IORESOURCE_DISABLED);
 }
 EXPORT_SYMBOL_GPL(acpi_dev_resource_io);
 
-/**
- * acpi_dev_resource_address_space - Extract ACPI address space information.
- * @ares: Input ACPI resource object.
- * @res: Output generic resource object.
- *
- * Check if the given ACPI resource object represents an address space resource
- * and if that's the case, use the information in it to populate the generic
- * resource object pointed to by @res.
- */
-bool acpi_dev_resource_address_space(struct acpi_resource *ares,
-                                    struct resource *res)
+static bool acpi_decode_space(struct resource_win *win,
+                             struct acpi_resource_address *addr,
+                             struct acpi_address64_attribute *attr)
 {
-       acpi_status status;
-       struct acpi_resource_address64 addr;
-       bool window;
-       u64 len;
-       u8 io_decode;
+       u8 iodec = attr->granularity == 0xfff ? ACPI_DECODE_10 : ACPI_DECODE_16;
+       bool wp = addr->info.mem.write_protect;
+       u64 len = attr->address_length;
+       struct resource *res = &win->res;
 
-       switch (ares->type) {
-       case ACPI_RESOURCE_TYPE_ADDRESS16:
-       case ACPI_RESOURCE_TYPE_ADDRESS32:
-       case ACPI_RESOURCE_TYPE_ADDRESS64:
-               break;
-       default:
-               return false;
-       }
+       /*
+        * Filter out invalid descriptor according to ACPI Spec 5.0, section
+        * 6.4.3.5 Address Space Resource Descriptors.
+        */
+       if ((addr->min_address_fixed != addr->max_address_fixed && len) ||
+           (addr->min_address_fixed && addr->max_address_fixed && !len))
+               pr_debug("ACPI: Invalid address space min_addr_fix %d, max_addr_fix %d, len %llx\n",
+                        addr->min_address_fixed, addr->max_address_fixed, len);
 
-       status = acpi_resource_to_address64(ares, &addr);
-       if (ACPI_FAILURE(status))
-               return false;
+       res->start = attr->minimum;
+       res->end = attr->maximum;
 
-       res->start = addr.address.minimum;
-       res->end = addr.address.maximum;
-       window = addr.producer_consumer == ACPI_PRODUCER;
+       /*
+        * For bridges that translate addresses across the bridge,
+        * translation_offset is the offset that must be added to the
+        * address on the secondary side to obtain the address on the
+        * primary side. Non-bridge devices must list 0 for all Address
+        * Translation offset bits.
+        */
+       if (addr->producer_consumer == ACPI_PRODUCER) {
+               res->start += attr->translation_offset;
+               res->end += attr->translation_offset;
+       } else if (attr->translation_offset) {
+               pr_debug("ACPI: translation_offset(%lld) is invalid for non-bridge device.\n",
+                        attr->translation_offset);
+       }
 
-       switch(addr.resource_type) {
+       switch (addr->resource_type) {
        case ACPI_MEMORY_RANGE:
-               len = addr.address.maximum - addr.address.minimum + 1;
-               res->flags = acpi_dev_memresource_flags(len,
-                                               addr.info.mem.write_protect,
-                                               window);
+               acpi_dev_memresource_flags(res, len, wp);
                break;
        case ACPI_IO_RANGE:
-               io_decode = addr.address.granularity == 0xfff ?
-                               ACPI_DECODE_10 : ACPI_DECODE_16;
-               res->flags = acpi_dev_ioresource_flags(addr.address.minimum,
-                                                      addr.address.maximum,
-                                                      io_decode, window);
+               acpi_dev_ioresource_flags(res, len, iodec);
                break;
        case ACPI_BUS_NUMBER_RANGE:
                res->flags = IORESOURCE_BUS;
                break;
        default:
-               res->flags = 0;
+               return false;
        }
 
-       return true;
+       win->offset = attr->translation_offset;
+
+       if (addr->producer_consumer == ACPI_PRODUCER)
+               res->flags |= IORESOURCE_WINDOW;
+
+       if (addr->info.mem.caching == ACPI_PREFETCHABLE_MEMORY)
+               res->flags |= IORESOURCE_PREFETCH;
+
+       return !(res->flags & IORESOURCE_DISABLED);
+}
+
+/**
+ * acpi_dev_resource_address_space - Extract ACPI address space information.
+ * @ares: Input ACPI resource object.
+ * @win: Output generic resource object.
+ *
+ * Check if the given ACPI resource object represents an address space resource
+ * and if that's the case, use the information in it to populate the generic
+ * resource object pointed to by @win.
+ *
+ * Return:
+ * 1) false with win->res.flags setting to zero: not the expected resource type
+ * 2) false with IORESOURCE_DISABLED in win->res.flags: valid unassigned
+ *    resource
+ * 3) true: valid assigned resource
+ */
+bool acpi_dev_resource_address_space(struct acpi_resource *ares,
+                                    struct resource_win *win)
+{
+       struct acpi_resource_address64 addr;
+
+       win->res.flags = 0;
+       if (ACPI_FAILURE(acpi_resource_to_address64(ares, &addr)))
+               return false;
+
+       return acpi_decode_space(win, (struct acpi_resource_address *)&addr,
+                                &addr.address);
 }
 EXPORT_SYMBOL_GPL(acpi_dev_resource_address_space);
 
 /**
  * acpi_dev_resource_ext_address_space - Extract ACPI address space information.
  * @ares: Input ACPI resource object.
- * @res: Output generic resource object.
+ * @win: Output generic resource object.
  *
  * Check if the given ACPI resource object represents an extended address space
  * resource and if that's the case, use the information in it to populate the
- * generic resource object pointed to by @res.
+ * generic resource object pointed to by @win.
+ *
+ * Return:
+ * 1) false with win->res.flags setting to zero: not the expected resource type
+ * 2) false with IORESOURCE_DISABLED in win->res.flags: valid unassigned
+ *    resource
+ * 3) true: valid assigned resource
  */
 bool acpi_dev_resource_ext_address_space(struct acpi_resource *ares,
-                                        struct resource *res)
+                                        struct resource_win *win)
 {
        struct acpi_resource_extended_address64 *ext_addr;
-       bool window;
-       u64 len;
-       u8 io_decode;
 
+       win->res.flags = 0;
        if (ares->type != ACPI_RESOURCE_TYPE_EXTENDED_ADDRESS64)
                return false;
 
        ext_addr = &ares->data.ext_address64;
 
-       res->start = ext_addr->address.minimum;
-       res->end = ext_addr->address.maximum;
-       window = ext_addr->producer_consumer == ACPI_PRODUCER;
-
-       switch(ext_addr->resource_type) {
-       case ACPI_MEMORY_RANGE:
-               len = ext_addr->address.maximum - ext_addr->address.minimum + 1;
-               res->flags = acpi_dev_memresource_flags(len,
-                                       ext_addr->info.mem.write_protect,
-                                       window);
-               break;
-       case ACPI_IO_RANGE:
-               io_decode = ext_addr->address.granularity == 0xfff ?
-                               ACPI_DECODE_10 : ACPI_DECODE_16;
-               res->flags = acpi_dev_ioresource_flags(ext_addr->address.minimum,
-                                                      ext_addr->address.maximum,
-                                                      io_decode, window);
-               break;
-       case ACPI_BUS_NUMBER_RANGE:
-               res->flags = IORESOURCE_BUS;
-               break;
-       default:
-               res->flags = 0;
-       }
-
-       return true;
+       return acpi_decode_space(win, (struct acpi_resource_address *)ext_addr,
+                                &ext_addr->address);
 }
 EXPORT_SYMBOL_GPL(acpi_dev_resource_ext_address_space);
 
@@ -310,7 +333,7 @@ static void acpi_dev_irqresource_disabled(struct resource *res, u32 gsi)
 {
        res->start = gsi;
        res->end = gsi;
-       res->flags = IORESOURCE_IRQ | IORESOURCE_DISABLED;
+       res->flags = IORESOURCE_IRQ | IORESOURCE_DISABLED | IORESOURCE_UNSET;
 }
 
 static void acpi_dev_get_irqresource(struct resource *res, u32 gsi,
@@ -369,6 +392,11 @@ static void acpi_dev_get_irqresource(struct resource *res, u32 gsi,
  * represented by the resource and populate the generic resource object pointed
  * to by @res accordingly.  If the registration of the GSI is not successful,
  * IORESOURCE_DISABLED will be set it that object's flags.
+ *
+ * Return:
+ * 1) false with res->flags setting to zero: not the expected resource type
+ * 2) false with IORESOURCE_DISABLED in res->flags: valid unassigned resource
+ * 3) true: valid assigned resource
  */
 bool acpi_dev_resource_interrupt(struct acpi_resource *ares, int index,
                                 struct resource *res)
@@ -402,6 +430,7 @@ bool acpi_dev_resource_interrupt(struct acpi_resource *ares, int index,
                                         ext_irq->sharable, false);
                break;
        default:
+               res->flags = 0;
                return false;
        }
 
@@ -415,12 +444,7 @@ EXPORT_SYMBOL_GPL(acpi_dev_resource_interrupt);
  */
 void acpi_dev_free_resource_list(struct list_head *list)
 {
-       struct resource_list_entry *rentry, *re;
-
-       list_for_each_entry_safe(rentry, re, list, node) {
-               list_del(&rentry->node);
-               kfree(rentry);
-       }
+       resource_list_free(list);
 }
 EXPORT_SYMBOL_GPL(acpi_dev_free_resource_list);
 
@@ -432,18 +456,19 @@ struct res_proc_context {
        int error;
 };
 
-static acpi_status acpi_dev_new_resource_entry(struct resource *r,
+static acpi_status acpi_dev_new_resource_entry(struct resource_win *win,
                                               struct res_proc_context *c)
 {
-       struct resource_list_entry *rentry;
+       struct resource_entry *rentry;
 
-       rentry = kmalloc(sizeof(*rentry), GFP_KERNEL);
+       rentry = resource_list_create_entry(NULL, 0);
        if (!rentry) {
                c->error = -ENOMEM;
                return AE_NO_MEMORY;
        }
-       rentry->res = *r;
-       list_add_tail(&rentry->node, c->list);
+       *rentry->res = win->res;
+       rentry->offset = win->offset;
+       resource_list_add_tail(rentry, c->list);
        c->count++;
        return AE_OK;
 }
@@ -452,7 +477,8 @@ static acpi_status acpi_dev_process_resource(struct acpi_resource *ares,
                                             void *context)
 {
        struct res_proc_context *c = context;
-       struct resource r;
+       struct resource_win win;
+       struct resource *res = &win.res;
        int i;
 
        if (c->preproc) {
@@ -467,18 +493,18 @@ static acpi_status acpi_dev_process_resource(struct acpi_resource *ares,
                }
        }
 
-       memset(&r, 0, sizeof(r));
+       memset(&win, 0, sizeof(win));
 
-       if (acpi_dev_resource_memory(ares, &r)
-           || acpi_dev_resource_io(ares, &r)
-           || acpi_dev_resource_address_space(ares, &r)
-           || acpi_dev_resource_ext_address_space(ares, &r))
-               return acpi_dev_new_resource_entry(&r, c);
+       if (acpi_dev_resource_memory(ares, res)
+           || acpi_dev_resource_io(ares, res)
+           || acpi_dev_resource_address_space(ares, &win)
+           || acpi_dev_resource_ext_address_space(ares, &win))
+               return acpi_dev_new_resource_entry(&win, c);
 
-       for (i = 0; acpi_dev_resource_interrupt(ares, i, &r); i++) {
+       for (i = 0; acpi_dev_resource_interrupt(ares, i, res); i++) {
                acpi_status status;
 
-               status = acpi_dev_new_resource_entry(&r, c);
+               status = acpi_dev_new_resource_entry(&win, c);
                if (ACPI_FAILURE(status))
                        return status;
        }
@@ -503,7 +529,7 @@ static acpi_status acpi_dev_process_resource(struct acpi_resource *ares,
  * returned as the final error code.
  *
  * The resultant struct resource objects are put on the list pointed to by
- * @list, that must be empty initially, as members of struct resource_list_entry
+ * @list, that must be empty initially, as members of struct resource_entry
  * objects.  Callers of this routine should use %acpi_dev_free_resource_list() to
  * free that list.
  *
@@ -538,3 +564,58 @@ int acpi_dev_get_resources(struct acpi_device *adev, struct list_head *list,
        return c.count;
 }
 EXPORT_SYMBOL_GPL(acpi_dev_get_resources);
+
+/**
+ * acpi_dev_filter_resource_type - Filter ACPI resource according to resource
+ *                                types
+ * @ares: Input ACPI resource object.
+ * @types: Valid resource types of IORESOURCE_XXX
+ *
+ * This is a hepler function to support acpi_dev_get_resources(), which filters
+ * ACPI resource objects according to resource types.
+ */
+int acpi_dev_filter_resource_type(struct acpi_resource *ares,
+                                 unsigned long types)
+{
+       unsigned long type = 0;
+
+       switch (ares->type) {
+       case ACPI_RESOURCE_TYPE_MEMORY24:
+       case ACPI_RESOURCE_TYPE_MEMORY32:
+       case ACPI_RESOURCE_TYPE_FIXED_MEMORY32:
+               type = IORESOURCE_MEM;
+               break;
+       case ACPI_RESOURCE_TYPE_IO:
+       case ACPI_RESOURCE_TYPE_FIXED_IO:
+               type = IORESOURCE_IO;
+               break;
+       case ACPI_RESOURCE_TYPE_IRQ:
+       case ACPI_RESOURCE_TYPE_EXTENDED_IRQ:
+               type = IORESOURCE_IRQ;
+               break;
+       case ACPI_RESOURCE_TYPE_DMA:
+       case ACPI_RESOURCE_TYPE_FIXED_DMA:
+               type = IORESOURCE_DMA;
+               break;
+       case ACPI_RESOURCE_TYPE_GENERIC_REGISTER:
+               type = IORESOURCE_REG;
+               break;
+       case ACPI_RESOURCE_TYPE_ADDRESS16:
+       case ACPI_RESOURCE_TYPE_ADDRESS32:
+       case ACPI_RESOURCE_TYPE_ADDRESS64:
+       case ACPI_RESOURCE_TYPE_EXTENDED_ADDRESS64:
+               if (ares->data.address.resource_type == ACPI_MEMORY_RANGE)
+                       type = IORESOURCE_MEM;
+               else if (ares->data.address.resource_type == ACPI_IO_RANGE)
+                       type = IORESOURCE_IO;
+               else if (ares->data.address.resource_type ==
+                        ACPI_BUS_NUMBER_RANGE)
+                       type = IORESOURCE_BUS;
+               break;
+       default:
+               break;
+       }
+
+       return (type & types) ? 0 : 1;
+}
+EXPORT_SYMBOL_GPL(acpi_dev_filter_resource_type);
index de361a156b341ab85a0b22490f2ff9407c93ce30..5a635646e05cfe87a9f92083c5864827c669ccee 100644 (file)
@@ -43,7 +43,7 @@ static int acpi_dma_parse_resource_group(const struct acpi_csrt_group *grp,
 {
        const struct acpi_csrt_shared_info *si;
        struct list_head resource_list;
-       struct resource_list_entry *rentry;
+       struct resource_entry *rentry;
        resource_size_t mem = 0, irq = 0;
        int ret;
 
@@ -56,10 +56,10 @@ static int acpi_dma_parse_resource_group(const struct acpi_csrt_group *grp,
                return 0;
 
        list_for_each_entry(rentry, &resource_list, node) {
-               if (resource_type(&rentry->res) == IORESOURCE_MEM)
-                       mem = rentry->res.start;
-               else if (resource_type(&rentry->res) == IORESOURCE_IRQ)
-                       irq = rentry->res.start;
+               if (resource_type(rentry->res) == IORESOURCE_MEM)
+                       mem = rentry->res->start;
+               else if (resource_type(rentry->res) == IORESOURCE_IRQ)
+                       irq = rentry->res->start;
        }
 
        acpi_dev_free_resource_list(&resource_list);
index 88471d3d98cd6cd01bb250f38e7f7cdfc3379152..62426d81a4d656c7dfd57c32a6a5bfd15398c6ca 100644 (file)
@@ -140,6 +140,7 @@ int of_pci_get_host_bridge_resources(struct device_node *dev,
                        unsigned char busno, unsigned char bus_max,
                        struct list_head *resources, resource_size_t *io_base)
 {
+       struct resource_entry *window;
        struct resource *res;
        struct resource *bus_range;
        struct of_pci_range range;
@@ -225,6 +226,8 @@ int of_pci_get_host_bridge_resources(struct device_node *dev,
 conversion_failed:
        kfree(res);
 parse_failed:
+       resource_list_for_each_entry(window, resources)
+               kfree(window->res);
        pci_free_resource_list(resources);
        return err;
 }
index 8fb16188cd82aaff9d346a70f46e0257e468fe29..90fa3a78fb7ce18018566f2f1f63e9c9f9be1dfd 100644 (file)
 void pci_add_resource_offset(struct list_head *resources, struct resource *res,
                             resource_size_t offset)
 {
-       struct pci_host_bridge_window *window;
+       struct resource_entry *entry;
 
-       window = kzalloc(sizeof(struct pci_host_bridge_window), GFP_KERNEL);
-       if (!window) {
+       entry = resource_list_create_entry(res, 0);
+       if (!entry) {
                printk(KERN_ERR "PCI: can't add host bridge window %pR\n", res);
                return;
        }
 
-       window->res = res;
-       window->offset = offset;
-       list_add_tail(&window->list, resources);
+       entry->offset = offset;
+       resource_list_add_tail(entry, resources);
 }
 EXPORT_SYMBOL(pci_add_resource_offset);
 
@@ -42,12 +41,7 @@ EXPORT_SYMBOL(pci_add_resource);
 
 void pci_free_resource_list(struct list_head *resources)
 {
-       struct pci_host_bridge_window *window, *tmp;
-
-       list_for_each_entry_safe(window, tmp, resources, list) {
-               list_del(&window->list);
-               kfree(window);
-       }
+       resource_list_free(resources);
 }
 EXPORT_SYMBOL(pci_free_resource_list);
 
index 0e5f3c95af5bd75d288d2067b79aacc6abd65a94..39b2dbe585aae651c930704eb4f1f53a68c66203 100644 (file)
@@ -35,10 +35,10 @@ void pcibios_resource_to_bus(struct pci_bus *bus, struct pci_bus_region *region,
                             struct resource *res)
 {
        struct pci_host_bridge *bridge = find_pci_host_bridge(bus);
-       struct pci_host_bridge_window *window;
+       struct resource_entry *window;
        resource_size_t offset = 0;
 
-       list_for_each_entry(window, &bridge->windows, list) {
+       resource_list_for_each_entry(window, &bridge->windows) {
                if (resource_contains(window->res, res)) {
                        offset = window->offset;
                        break;
@@ -60,10 +60,10 @@ void pcibios_bus_to_resource(struct pci_bus *bus, struct resource *res,
                             struct pci_bus_region *region)
 {
        struct pci_host_bridge *bridge = find_pci_host_bridge(bus);
-       struct pci_host_bridge_window *window;
+       struct resource_entry *window;
        resource_size_t offset = 0;
 
-       list_for_each_entry(window, &bridge->windows, list) {
+       resource_list_for_each_entry(window, &bridge->windows) {
                struct pci_bus_region bus_region;
 
                if (resource_type(res) != resource_type(window->res))
index 6eb1aa75bd378669c4c6f8419ca7f48155236eef..aee3c620ecf98994e6528c0111fd00bf5579030f 100644 (file)
@@ -149,14 +149,14 @@ static int gen_pci_parse_request_of_pci_ranges(struct gen_pci *pci)
        struct device *dev = pci->host.dev.parent;
        struct device_node *np = dev->of_node;
        resource_size_t iobase;
-       struct pci_host_bridge_window *win;
+       struct resource_entry *win;
 
        err = of_pci_get_host_bridge_resources(np, 0, 0xff, &pci->resources,
                                               &iobase);
        if (err)
                return err;
 
-       list_for_each_entry(win, &pci->resources, list) {
+       resource_list_for_each_entry(win, &pci->resources) {
                struct resource *parent, *res = win->res;
 
                switch (resource_type(res)) {
index b1d0596457c53995cba5c0f084ac3c28fa2cfa91..a704257bab7f05ad2d71ae297ebd209cea58d51e 100644 (file)
@@ -401,11 +401,11 @@ static int xgene_pcie_map_ranges(struct xgene_pcie_port *port,
                                 struct list_head *res,
                                 resource_size_t io_base)
 {
-       struct pci_host_bridge_window *window;
+       struct resource_entry *window;
        struct device *dev = port->dev;
        int ret;
 
-       list_for_each_entry(window, res, list) {
+       resource_list_for_each_entry(window, res) {
                struct resource *res = window->res;
                u64 restype = resource_type(res);
 
index ef3ebaf9a73885dcde116e8fbcd7d14567b85ce1..601261df76633cb612966423d82cab2d6b1ad641 100644 (file)
@@ -737,7 +737,7 @@ static int xilinx_pcie_parse_and_add_res(struct xilinx_pcie_port *port)
        resource_size_t offset;
        struct of_pci_range_parser parser;
        struct of_pci_range range;
-       struct pci_host_bridge_window *win;
+       struct resource_entry *win;
        int err = 0, mem_resno = 0;
 
        /* Get the ranges */
@@ -807,7 +807,7 @@ static int xilinx_pcie_parse_and_add_res(struct xilinx_pcie_port *port)
 
 free_resources:
        release_child_resources(&iomem_resource);
-       list_for_each_entry(win, &port->resources, list)
+       resource_list_for_each_entry(win, &port->resources)
                devm_kfree(dev, win->res);
        pci_free_resource_list(&port->resources);
 
index 23212f8ae09b5e1d853d6ad11410731cc1a17505..8d2f400e96cb848260fb3882a385dae0259c7ee4 100644 (file)
@@ -1895,7 +1895,7 @@ struct pci_bus *pci_create_root_bus(struct device *parent, int bus,
        int error;
        struct pci_host_bridge *bridge;
        struct pci_bus *b, *b2;
-       struct pci_host_bridge_window *window, *n;
+       struct resource_entry *window, *n;
        struct resource *res;
        resource_size_t offset;
        char bus_addr[64];
@@ -1959,8 +1959,8 @@ struct pci_bus *pci_create_root_bus(struct device *parent, int bus,
                printk(KERN_INFO "PCI host bridge to bus %s\n", dev_name(&b->dev));
 
        /* Add initial resources to the bus */
-       list_for_each_entry_safe(window, n, resources, list) {
-               list_move_tail(&window->list, &bridge->windows);
+       resource_list_for_each_entry_safe(window, n, resources) {
+               list_move_tail(&window->node, &bridge->windows);
                res = window->res;
                offset = window->offset;
                if (res->flags & IORESOURCE_BUS)
@@ -2060,12 +2060,12 @@ void pci_bus_release_busn_res(struct pci_bus *b)
 struct pci_bus *pci_scan_root_bus(struct device *parent, int bus,
                struct pci_ops *ops, void *sysdata, struct list_head *resources)
 {
-       struct pci_host_bridge_window *window;
+       struct resource_entry *window;
        bool found = false;
        struct pci_bus *b;
        int max;
 
-       list_for_each_entry(window, resources, list)
+       resource_list_for_each_entry(window, resources)
                if (window->res->flags & IORESOURCE_BUS) {
                        found = true;
                        break;
index 2d9bc789af0f8dc1d5f2bf7961f8760800f36f78..ff0356fb378ff514984fac72383f78a01ed93487 100644 (file)
@@ -180,20 +180,21 @@ static acpi_status pnpacpi_allocated_resource(struct acpi_resource *res,
        struct pnp_dev *dev = data;
        struct acpi_resource_dma *dma;
        struct acpi_resource_vendor_typed *vendor_typed;
-       struct resource r = {0};
+       struct resource_win win = {{0}, 0};
+       struct resource *r = &win.res;
        int i, flags;
 
-       if (acpi_dev_resource_address_space(res, &r)
-           || acpi_dev_resource_ext_address_space(res, &r)) {
-               pnp_add_resource(dev, &r);
+       if (acpi_dev_resource_address_space(res, &win)
+           || acpi_dev_resource_ext_address_space(res, &win)) {
+               pnp_add_resource(dev, &win.res);
                return AE_OK;
        }
 
-       r.flags = 0;
-       if (acpi_dev_resource_interrupt(res, 0, &r)) {
-               pnpacpi_add_irqresource(dev, &r);
-               for (i = 1; acpi_dev_resource_interrupt(res, i, &r); i++)
-                       pnpacpi_add_irqresource(dev, &r);
+       r->flags = 0;
+       if (acpi_dev_resource_interrupt(res, 0, r)) {
+               pnpacpi_add_irqresource(dev, r);
+               for (i = 1; acpi_dev_resource_interrupt(res, i, r); i++)
+                       pnpacpi_add_irqresource(dev, r);
 
                if (i > 1) {
                        /*
@@ -209,7 +210,7 @@ static acpi_status pnpacpi_allocated_resource(struct acpi_resource *res,
                        }
                }
                return AE_OK;
-       } else if (r.flags & IORESOURCE_DISABLED) {
+       } else if (r->flags & IORESOURCE_DISABLED) {
                pnp_add_irq_resource(dev, 0, IORESOURCE_DISABLED);
                return AE_OK;
        }
@@ -218,13 +219,13 @@ static acpi_status pnpacpi_allocated_resource(struct acpi_resource *res,
        case ACPI_RESOURCE_TYPE_MEMORY24:
        case ACPI_RESOURCE_TYPE_MEMORY32:
        case ACPI_RESOURCE_TYPE_FIXED_MEMORY32:
-               if (acpi_dev_resource_memory(res, &r))
-                       pnp_add_resource(dev, &r);
+               if (acpi_dev_resource_memory(res, r))
+                       pnp_add_resource(dev, r);
                break;
        case ACPI_RESOURCE_TYPE_IO:
        case ACPI_RESOURCE_TYPE_FIXED_IO:
-               if (acpi_dev_resource_io(res, &r))
-                       pnp_add_resource(dev, &r);
+               if (acpi_dev_resource_io(res, r))
+                       pnp_add_resource(dev, r);
                break;
        case ACPI_RESOURCE_TYPE_DMA:
                dma = &res->data.dma;
index d459cd17b477600cadf54ad2a227b66c5638112f..24c7aa8b1d20c6fce9dd7ede9d051d04afc7c07d 100644 (file)
@@ -27,6 +27,7 @@
 
 #include <linux/errno.h>
 #include <linux/ioport.h>      /* for struct resource */
+#include <linux/resource_ext.h>
 #include <linux/device.h>
 #include <linux/property.h>
 
@@ -151,6 +152,10 @@ int acpi_map_cpu(acpi_handle handle, int physid, int *pcpu);
 int acpi_unmap_cpu(int cpu);
 #endif /* CONFIG_ACPI_HOTPLUG_CPU */
 
+#ifdef CONFIG_ACPI_HOTPLUG_IOAPIC
+int acpi_get_ioapic_id(acpi_handle handle, u32 gsi_base, u64 *phys_addr);
+#endif
+
 int acpi_register_ioapic(acpi_handle handle, u64 phys_addr, u32 gsi_base);
 int acpi_unregister_ioapic(acpi_handle handle, u32 gsi_base);
 int acpi_ioapic_registered(acpi_handle handle, u32 gsi_base);
@@ -288,22 +293,25 @@ extern int pnpacpi_disabled;
 bool acpi_dev_resource_memory(struct acpi_resource *ares, struct resource *res);
 bool acpi_dev_resource_io(struct acpi_resource *ares, struct resource *res);
 bool acpi_dev_resource_address_space(struct acpi_resource *ares,
-                                    struct resource *res);
+                                    struct resource_win *win);
 bool acpi_dev_resource_ext_address_space(struct acpi_resource *ares,
-                                        struct resource *res);
+                                        struct resource_win *win);
 unsigned long acpi_dev_irq_flags(u8 triggering, u8 polarity, u8 shareable);
 bool acpi_dev_resource_interrupt(struct acpi_resource *ares, int index,
                                 struct resource *res);
 
-struct resource_list_entry {
-       struct list_head node;
-       struct resource res;
-};
-
 void acpi_dev_free_resource_list(struct list_head *list);
 int acpi_dev_get_resources(struct acpi_device *adev, struct list_head *list,
                           int (*preproc)(struct acpi_resource *, void *),
                           void *preproc_data);
+int acpi_dev_filter_resource_type(struct acpi_resource *ares,
+                                 unsigned long types);
+
+static inline int acpi_dev_filter_resource_type_cb(struct acpi_resource *ares,
+                                                  void *arg)
+{
+       return acpi_dev_filter_resource_type(ares, (unsigned long)arg);
+}
 
 int acpi_check_resource_conflict(const struct resource *res);
 
index 9603094ed59b2adb5defa9eb93a955c5ce93e543..faa60fa2631484155c2dcc11ec23763a93132436 100644 (file)
@@ -29,6 +29,7 @@
 #include <linux/atomic.h>
 #include <linux/device.h>
 #include <linux/io.h>
+#include <linux/resource_ext.h>
 #include <uapi/linux/pci.h>
 
 #include <linux/pci_ids.h>
@@ -397,16 +398,10 @@ static inline int pci_channel_offline(struct pci_dev *pdev)
        return (pdev->error_state != pci_channel_io_normal);
 }
 
-struct pci_host_bridge_window {
-       struct list_head list;
-       struct resource *res;           /* host bridge aperture (CPU address) */
-       resource_size_t offset;         /* bus address + offset = CPU address */
-};
-
 struct pci_host_bridge {
        struct device dev;
        struct pci_bus *bus;            /* root bus */
-       struct list_head windows;       /* pci_host_bridge_windows */
+       struct list_head windows;       /* resource_entry */
        void (*release_fn)(struct pci_host_bridge *);
        void *release_data;
 };
diff --git a/include/linux/resource_ext.h b/include/linux/resource_ext.h
new file mode 100644 (file)
index 0000000..e2bf63d
--- /dev/null
@@ -0,0 +1,77 @@
+/*
+ * Copyright (C) 2015, Intel Corporation
+ * Author: Jiang Liu <jiang.liu@linux.intel.com>
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ */
+#ifndef _LINUX_RESOURCE_EXT_H
+#define _LINUX_RESOURCE_EXT_H
+#include <linux/types.h>
+#include <linux/list.h>
+#include <linux/ioport.h>
+#include <linux/slab.h>
+
+/* Represent resource window for bridge devices */
+struct resource_win {
+       struct resource res;            /* In master (CPU) address space */
+       resource_size_t offset;         /* Translation offset for bridge */
+};
+
+/*
+ * Common resource list management data structure and interfaces to support
+ * ACPI, PNP and PCI host bridge etc.
+ */
+struct resource_entry {
+       struct list_head        node;
+       struct resource         *res;   /* In master (CPU) address space */
+       resource_size_t         offset; /* Translation offset for bridge */
+       struct resource         __res;  /* Default storage for res */
+};
+
+extern struct resource_entry *
+resource_list_create_entry(struct resource *res, size_t extra_size);
+extern void resource_list_free(struct list_head *head);
+
+static inline void resource_list_add(struct resource_entry *entry,
+                                    struct list_head *head)
+{
+       list_add(&entry->node, head);
+}
+
+static inline void resource_list_add_tail(struct resource_entry *entry,
+                                         struct list_head *head)
+{
+       list_add_tail(&entry->node, head);
+}
+
+static inline void resource_list_del(struct resource_entry *entry)
+{
+       list_del(&entry->node);
+}
+
+static inline void resource_list_free_entry(struct resource_entry *entry)
+{
+       kfree(entry);
+}
+
+static inline void
+resource_list_destroy_entry(struct resource_entry *entry)
+{
+       resource_list_del(entry);
+       resource_list_free_entry(entry);
+}
+
+#define resource_list_for_each_entry(entry, list)      \
+       list_for_each_entry((entry), (list), node)
+
+#define resource_list_for_each_entry_safe(entry, tmp, list)    \
+       list_for_each_entry_safe((entry), (tmp), (list), node)
+
+#endif /* _LINUX_RESOURCE_EXT_H */
index 0bcebffc4e77d5f45571e38ddc5dcc38f40594f4..19f2357dfda3fe88f7e0ddc6b29778176138a619 100644 (file)
@@ -22,6 +22,7 @@
 #include <linux/device.h>
 #include <linux/pfn.h>
 #include <linux/mm.h>
+#include <linux/resource_ext.h>
 #include <asm/io.h>
 
 
@@ -1529,6 +1530,30 @@ int iomem_is_exclusive(u64 addr)
        return err;
 }
 
+struct resource_entry *resource_list_create_entry(struct resource *res,
+                                                 size_t extra_size)
+{
+       struct resource_entry *entry;
+
+       entry = kzalloc(sizeof(*entry) + extra_size, GFP_KERNEL);
+       if (entry) {
+               INIT_LIST_HEAD(&entry->node);
+               entry->res = res ? res : &entry->__res;
+       }
+
+       return entry;
+}
+EXPORT_SYMBOL(resource_list_create_entry);
+
+void resource_list_free(struct list_head *head)
+{
+       struct resource_entry *entry, *tmp;
+
+       list_for_each_entry_safe(entry, tmp, head, node)
+               resource_list_destroy_entry(entry);
+}
+EXPORT_SYMBOL(resource_list_free);
+
 static int __init strict_iomem(char *str)
 {
        if (strstr(str, "relaxed"))