]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
Revert "nvme-pci: don't create a read hctx mapping without read queues"
authoryangerkun <yangerkun@huawei.com>
Tue, 23 Jul 2019 03:23:13 +0000 (11:23 +0800)
committerChristoph Hellwig <hch@lst.de>
Tue, 23 Jul 2019 15:47:02 +0000 (17:47 +0200)
This reverts commit 0298d5435276e7795b0b939d74827f6e775e7009.

With this patch, set 'poll_queues > hard queues' will lead to 'nr_read_queues = 0'
in nvme_calc_irq_sets. Then poll_queues setting can fail since dev->tagset.nr_maps
equals to 2 and nvme_pci_map_queues will not do map for poll queues.

Signed-off-by: yangerkun <yangerkun@huawei.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/pci.c

index dd10cf78f2d3eafe5ff233cf1c4b9f4c9f3fc8a0..db160cee42ad178e02b11cc15bb0229a9417f118 100644 (file)
@@ -2254,9 +2254,7 @@ static int nvme_dev_add(struct nvme_dev *dev)
        if (!dev->ctrl.tagset) {
                dev->tagset.ops = &nvme_mq_ops;
                dev->tagset.nr_hw_queues = dev->online_queues - 1;
-               dev->tagset.nr_maps = 1; /* default */
-               if (dev->io_queues[HCTX_TYPE_READ])
-                       dev->tagset.nr_maps++;
+               dev->tagset.nr_maps = 2; /* default + read */
                if (dev->io_queues[HCTX_TYPE_POLL])
                        dev->tagset.nr_maps++;
                dev->tagset.timeout = NVME_IO_TIMEOUT;