]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commitdiff
scsi: qla2xxx: Fix target multiqueue configuration
authorMichael Hernandez <michael.hernandez@cavium.com>
Wed, 23 Aug 2017 22:04:56 +0000 (15:04 -0700)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 28 Sep 2017 14:34:56 +0000 (10:34 -0400)
BugLink: http://bugs.launchpad.net/bugs/1720154
commit b7edfa235effb4b4a9816c2345620b11609c123e upstream.

Following error will be logged in to message file while trying to
configure target with multiqueue.

"Cmd 0x1f aborted with timeout since ISP Abort is pending"
"qla25xx_init_queues Rsp que: 1 init failed."

Fixes: 82de802ad46e ("scsi: qla2xxx: Preparation for Target MQ.")
Signed-off-by: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Michael Hernandez <michael.hernandez@cavium.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
drivers/scsi/qla2xxx/qla_isr.c
drivers/scsi/qla2xxx/qla_mbx.c
drivers/scsi/qla2xxx/qla_target.c

index 7b3b702ef6222cab385bb90d346f9eae679b1a95..ec2c398f5663b9fc3a8a58afaa52ec1d85f4b2e6 100644 (file)
@@ -3429,7 +3429,7 @@ msix_register_fail:
        }
 
        /* Enable MSI-X vector for response queue update for queue 0 */
-       if (IS_QLA25XX(ha) || IS_QLA83XX(ha) || IS_QLA27XX(ha)) {
+       if (IS_QLA83XX(ha) || IS_QLA27XX(ha)) {
                if (ha->msixbase && ha->mqiobase &&
                    (ha->max_rsp_queues > 1 || ha->max_req_queues > 1 ||
                     ql2xmqsupport))
index 7c6d1a40401121dce41279d32adce5104147b203..7308dd41bc5dc05eb7349698ecd5cdd3179beca6 100644 (file)
@@ -54,6 +54,7 @@ static struct rom_cmd {
        { MBC_GET_MEM_OFFLOAD_CNTRL_STAT },
        { MBC_GET_RETRY_COUNT },
        { MBC_TRACE_CONTROL },
+       { MBC_INITIALIZE_MULTIQ },
 };
 
 static int is_rom_cmd(uint16_t cmd)
index e101cd3043b94539a2893e77aa9949c8fd9c7acb..4e2a647730605b47943ba703c8a6f2d163fc1865 100644 (file)
@@ -6796,7 +6796,7 @@ qlt_probe_one_stage1(struct scsi_qla_host *base_vha, struct qla_hw_data *ha)
        if (!QLA_TGT_MODE_ENABLED())
                return;
 
-       if  (ha->mqenable || IS_QLA83XX(ha) || IS_QLA27XX(ha)) {
+       if  (IS_QLA83XX(ha) || IS_QLA27XX(ha)) {
                ISP_ATIO_Q_IN(base_vha) = &ha->mqiobase->isp25mq.atio_q_in;
                ISP_ATIO_Q_OUT(base_vha) = &ha->mqiobase->isp25mq.atio_q_out;
        } else {