]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
staging: lustre: llite: avoid a deadlock in page write
authorJinshan Xiong <jinshan.xiong@intel.com>
Tue, 16 Aug 2016 20:18:44 +0000 (16:18 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 21 Aug 2016 13:57:35 +0000 (15:57 +0200)
For a partial page write, it will have to issue a READ RPC firstly
to get a full uptodate page. If another page is already locked by
this thread it can easily cause deadlock.

Signed-off-by: Jinshan Xiong <jinshan.xiong@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4873
Reviewed-on: http://review.whamcloud.com/9928
Reviewed-by: Bobi Jam <bobijam@gmail.com>
Reviewed-by: Niu Yawei <yawei.niu@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/llite/rw26.c

index d98c7acc0832518287a3bccee2b5c36482ed55b7..c14a1b6805053e121f008288e080aa96e349e696 100644 (file)
@@ -506,8 +506,9 @@ static int ll_write_begin(struct file *file, struct address_space *mapping,
        env = lcc->lcc_env;
        io  = lcc->lcc_io;
 
-       /* To avoid deadlock, try to lock page first. */
-       vmpage = grab_cache_page_nowait(mapping, index);
+       if (likely(to == PAGE_SIZE)) /* LU-4873 */
+               /* To avoid deadlock, try to lock page first. */
+               vmpage = grab_cache_page_nowait(mapping, index);
        if (unlikely(!vmpage || PageDirty(vmpage) || PageWriteback(vmpage))) {
                struct vvp_io *vio = vvp_env_io(env);
                struct cl_page_list *plist = &vio->u.write.vui_queue;