]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
rtw88: fix multiple definition of rtw_pm_ops
authorPing-Ke Shih <pkshih@realtek.com>
Tue, 8 Dec 2020 01:37:46 +0000 (09:37 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 8 Dec 2020 07:34:35 +0000 (09:34 +0200)
'const struct dev_pm_ops rtw_pm_ops' is declared by pci.c, and it should be
declare as 'extern' in pci.h. Without 'extern' causes every file including
pci.h has an individual instance of rtw_pm_ops but not reference to the one
declared in pci.c

If kernel config, like test robot, doesn't build driver as module, it leads
multiple definition.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 2e86ef413ab3 ("rtw88: pci: Add prototypes for .probe, .remove and .shutdown")
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20201208013746.11065-1-pkshih@realtek.com
drivers/net/wireless/realtek/rtw88/pci.h

index cda56919a5f0fa4aa472d8d19956c04051c94650..7cdefe229824fb57031e069f3a7711f77bbc53d4 100644 (file)
@@ -214,7 +214,7 @@ struct rtw_pci {
        void __iomem *mmap;
 };
 
-const struct dev_pm_ops rtw_pm_ops;
+extern const struct dev_pm_ops rtw_pm_ops;
 
 int rtw_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id);
 void rtw_pci_remove(struct pci_dev *pdev);