raft: Fix error leak on failure while saving snapshot.

Error should be destroyed before return.

Fixes: 1b1d2e6daa56 ("ovsdb: Introduce experimental support for clustered databases.")
Acked-by: Han Zhou <hzhou@ovn.org>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>

diff --git a/ovsdb/raft.c b/ovsdb/raft.c
index 3411323aa0d18860f210704de8195276b6a1e064..728d601751166cf49cb6c0d1900f593ab7f9ea9b 100644 (file)
--- a/ovsdb/raft.c
+++ b/ovsdb/raft.c
@@ -3987,7 +3987,7 @@ raft_handle_install_snapshot_request__(
     struct ovsdb_error *error = raft_save_snapshot(raft, new_log_start,
                                                    &new_snapshot);
     if (error) {
-        char *error_s = ovsdb_error_to_string(error);
+        char *error_s = ovsdb_error_to_string_free(error);
         VLOG_WARN("could not save snapshot: %s", error_s);
         free(error_s);
         return false;