]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
media: dvb-frontends: ves1820: use 64-bit arithmetic instead of 32-bit
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 6 Feb 2018 16:47:09 +0000 (11:47 -0500)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 26 Feb 2018 13:07:38 +0000 (08:07 -0500)
Add suffix ULL to constant 10 in order to give the compiler complete
information about the proper arithmetic to use. Notice that this
constant is used in a context that expects an expression of type
u64 (64 bits, unsigned).

The expression fpxin = state->config->xin * 10 is currently being
evaluated using 32-bit arithmetic.

Addresses-Coverity-ID: 200604 ("Unintentional integer overflow")

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/dvb-frontends/ves1820.c

index 1d897928991516ecb088aadcd57f869e33e2e306..17600989f1213076c3cba75c5a2687f885be9c05 100644 (file)
@@ -137,7 +137,7 @@ static int ves1820_set_symbolrate(struct ves1820_state *state, u32 symbolrate)
                NDEC = 3;
 
        /* yeuch! */
-       fpxin = state->config->xin * 10;
+       fpxin = state->config->xin * 10ULL;
        fptmp = fpxin; do_div(fptmp, 123);
        if (symbolrate < fptmp)
                SFIL = 1;