r8169: enable HW csum and TSO

Enable HW csum and TSO per default except on known buggy chip versions.
Realtek confirmed that RTL8168evl has a HW issue with TSO.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index f771595403e0999ae11ace841097d0eccd66929c..61a23aee0eef8955962344a7dcbd5e8d3045ea3c 100644 (file)
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -6879,11 +6879,9 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 
        netif_napi_add(dev, &tp->napi, rtl8169_poll, NAPI_POLL_WEIGHT);
 
-       /* don't enable SG, IP_CSUM and TSO by default - it might not work
-        * properly for all devices */
-       dev->features |= NETIF_F_RXCSUM |
-               NETIF_F_HW_VLAN_CTAG_TX | NETIF_F_HW_VLAN_CTAG_RX;
-
+       dev->features |= NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO |
+               NETIF_F_RXCSUM | NETIF_F_HW_VLAN_CTAG_TX |
+               NETIF_F_HW_VLAN_CTAG_RX;
        dev->hw_features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO |
                NETIF_F_RXCSUM | NETIF_F_HW_VLAN_CTAG_TX |
                NETIF_F_HW_VLAN_CTAG_RX;
@@ -6903,6 +6901,7 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 
        if (rtl_chip_supports_csum_v2(tp)) {
                dev->hw_features |= NETIF_F_IPV6_CSUM | NETIF_F_TSO6;
+               dev->features |= NETIF_F_IPV6_CSUM | NETIF_F_TSO6;
                dev->gso_max_size = RTL_GSO_MAX_SIZE_V2;
                dev->gso_max_segs = RTL_GSO_MAX_SEGS_V2;
        } else {
@@ -6910,6 +6909,13 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
                dev->gso_max_segs = RTL_GSO_MAX_SEGS_V1;
        }
 
+       /* RTL8168e-vl has a HW issue with TSO */
+       if (tp->mac_version == RTL_GIGA_MAC_VER_34) {
+               dev->vlan_features &= ~NETIF_F_ALL_TSO;
+               dev->hw_features &= ~NETIF_F_ALL_TSO;
+               dev->features &= ~NETIF_F_ALL_TSO;
+       }
+
        dev->hw_features |= NETIF_F_RXALL;
        dev->hw_features |= NETIF_F_RXFCS;