]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
bus: mhi: core: Initialize bhie field in mhi_cntrl for RDDM capture
authorManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Tue, 24 Mar 2020 06:10:46 +0000 (11:40 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Mar 2020 14:51:08 +0000 (15:51 +0100)
The bhie field in mhi_cntrl needs to be initialized to proper register
base in order to make mhi_rddm_prepare() to work. Otherwise,
mhi_rddm_prepare() will cause NULL pointer dereference.

Fixes: 6fdfdd27328c ("bus: mhi: core: Add support for downloading RDDM image during panic")
Reported-by: Hemant Kumar <hemantk@codeaurora.org>
Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20200324061050.14845-4-manivannan.sadhasivam@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/bus/mhi/core/init.c

index d136f6c6ca78f1169c7e139c89b5423c8cc55789..f6e3c16225a72337b4ba75c6ae7f6a807e867b5d 100644 (file)
@@ -979,7 +979,8 @@ int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl)
                        goto bhie_error;
                }
 
-               memset_io(mhi_cntrl->regs + bhie_off + BHIE_RXVECADDR_LOW_OFFS,
+               mhi_cntrl->bhie = mhi_cntrl->regs + bhie_off;
+               memset_io(mhi_cntrl->bhie + BHIE_RXVECADDR_LOW_OFFS,
                          0, BHIE_RXVECSTATUS_OFFS - BHIE_RXVECADDR_LOW_OFFS +
                          4);