]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
scripts/checkpatch.pl: add check for declaration of pci_device_id
authorJoe Perches <joe@perches.com>
Tue, 26 Oct 2010 21:23:21 +0000 (14:23 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 26 Oct 2010 23:52:21 +0000 (16:52 -0700)
Signed-off-by: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
scripts/checkpatch.pl

index 2ec5fc6a40462930bcb37cc1fdfb59154f2373b1..90b54d4697fd2de9ae1dcecc80fc25cdcab63d21 100755 (executable)
@@ -1881,6 +1881,11 @@ sub process {
                                $herecurr);
                }
 
+# check for declarations of struct pci_device_id
+               if ($line =~ /\bstruct\s+pci_device_id\s+\w+\s*\[\s*\]\s*\=\s*\{/) {
+                       WARN("Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id\n" . $herecurr);
+               }
+
 # check for new typedefs, only function parameters and sparse annotations
 # make sense.
                if ($line =~ /\btypedef\s/ &&