]> git.proxmox.com Git - proxmox-backup.git/commitdiff
ui: system config: fix deleting DNS entries
authorDominik Csapak <d.csapak@proxmox.com>
Fri, 1 Mar 2024 09:03:41 +0000 (10:03 +0100)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Mon, 4 Mar 2024 13:50:10 +0000 (14:50 +0100)
While PVE and PMG use a rather brittle "replace whole config" style on
their DNS entry CRUD API, the PBS one was made with a per-entry level
granularity, so that single entries can modified, or deleted, without
touching the others.

But the UI from the widget-toolkit was made for the older PVE/PMG
behavior and did  not sent along the delete-array of to-be-deleted
keys.

Since widget-toolkit commit 8d161ac ("dns: update comment to avoid
coupling to downstream dependency") the DNS edit window supports
opting into that by setting the new `deleteEmpty` config parameter.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 [ TL: expand commit message ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
www/SystemConfiguration.js

index 860d85c0aea9bcd90b9a075bd29b0084215b42a3..e94fe7ca1a68d18bddf98d1e5972e7e0b7c7e272 100644 (file)
@@ -31,6 +31,7 @@ Ext.define('PBS.SystemConfiguration', {
                },
                {
                    xtype: 'proxmoxNodeDNSView',
+                   deleteEmpty: true,
                    title: gettext('DNS'),
                    nodename: 'localhost',
                },