]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
net: hns3: reset tqp while doing DOWN operation
authorHuazhong Tan <tanhuazhong@huawei.com>
Thu, 20 Dec 2018 03:52:02 +0000 (11:52 +0800)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Mon, 14 Jan 2019 09:28:55 +0000 (09:28 +0000)
BugLink: https://bugs.launchpad.net/bugs/1810457
While doing DOWN operation, the driver will reclaim the memory which has
already used for TX. If the hardware is processing this memory, it will
cause a RCB error to the hardware. According the hardware's description,
the driver should reset the tqp before reclaim the memory during DOWN.

Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 39cfbc9c4fc4a2888548c2624789e42e3f775721)
Signed-off-by: dann frazier <dann.frazier@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c

index 6080a16f89cae4b760e217c44b7705778cebc705..a6ea7c8c082febb66448490160de89fc7677ae9d 100644 (file)
@@ -5337,6 +5337,7 @@ static void hclge_ae_stop(struct hnae3_handle *handle)
 {
        struct hclge_vport *vport = hclge_get_vport(handle);
        struct hclge_dev *hdev = vport->back;
+       int i;
 
        set_bit(HCLGE_STATE_DOWN, &hdev->state);
 
@@ -5349,6 +5350,9 @@ static void hclge_ae_stop(struct hnae3_handle *handle)
                return;
        }
 
+       for (i = 0; i < handle->kinfo.num_tqps; i++)
+               hclge_reset_tqp(handle, i);
+
        /* Mac disable */
        hclge_cfg_mac_mode(hdev, false);
 
index 54df2cb4671393ea8487aec6647a0a9705b0a7b3..d99a5544e2db8ffc6c9d78cb521c5157a838d475 100644 (file)
@@ -1870,9 +1870,13 @@ static int hclgevf_ae_start(struct hnae3_handle *handle)
 static void hclgevf_ae_stop(struct hnae3_handle *handle)
 {
        struct hclgevf_dev *hdev = hclgevf_ae_get_hdev(handle);
+       int i;
 
        set_bit(HCLGEVF_STATE_DOWN, &hdev->state);
 
+       for (i = 0; i < handle->kinfo.num_tqps; i++)
+               hclgevf_reset_tqp(handle, i);
+
        /* reset tqp stats */
        hclgevf_reset_tqp_stats(handle);
        hclgevf_update_link_status(hdev, 0);