perf stat: Avoid segfaults caused by negated options

BugLink: https://bugs.launchpad.net/bugs/1837477
[ Upstream commit 51433ead1460fb3f46e1c34f68bb22fd2dd0f5d0 ]

Some 'perf stat' options do not make sense to be negated (event,
cgroup), some do not have negated path implemented (metrics). Due to
that, it is better to disable the "no-" prefix for them, since
otherwise, the later opt-parsing segfaults.

Before:

  $ perf stat --no-metrics -- ls
  Segmentation fault (core dumped)

After:

  $ perf stat --no-metrics -- ls
   Error: option `no-metrics' isn't available
   Usage: perf stat [<options>] [<command>]

Signed-off-by: Michael Petlan <mpetlan@redhat.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
LPU-Reference: 1485912065.62416880.1544457604340.JavaMail.zimbra@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 351f5fabd7e81e5cf70c37cc5e17b5d50fda6a57..8000c1a6c8b8f83b354ee2ab309350bc7c4b8837 100644 (file)
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -1822,7 +1822,7 @@ static int parse_metric_groups(const struct option *opt,
        return metricgroup__parse_groups(opt, str, &metric_events);
 }
 
-static const struct option stat_options[] = {
+static struct option stat_options[] = {
        OPT_BOOLEAN('T', "transaction", &transaction_run,
                    "hardware transaction statistics"),
        OPT_CALLBACK('e', "event", &evsel_list, "event",
@@ -2656,6 +2656,12 @@ int cmd_stat(int argc, const char **argv)
                return -ENOMEM;
 
        parse_events__shrink_config_terms();
+
+       /* String-parsing callback-based options would segfault when negated */
+       set_option_flag(stat_options, 'e', "event", PARSE_OPT_NONEG);
+       set_option_flag(stat_options, 'M', "metrics", PARSE_OPT_NONEG);
+       set_option_flag(stat_options, 'G', "cgroup", PARSE_OPT_NONEG);
+
        argc = parse_options_subcommand(argc, argv, stat_options, stat_subcommands,
                                        (const char **) stat_usage,
                                        PARSE_OPT_STOP_AT_NON_OPTION);