]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drm/aspeed: gfc_crtc: Make structure aspeed_gfx_funcs constant
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Tue, 13 Aug 2019 06:33:55 +0000 (12:03 +0530)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 14 Aug 2019 17:27:26 +0000 (19:27 +0200)
The static structure aspeed_gfx_funcs, of type
drm_simple_display_pipe_funcs, is used only as an argument to
drm_simple_display_pipe_init(), which does not modify it. Hence make it
constant to protect it from unintended modification.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20190813063355.25549-1-nishkadg.linux@gmail.com
drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c

index 15db9e426ec42e0b6ed1eb11f25058716e4e225d..2184b8be6fd4f1db8be6f451825787a2e81a25a8 100644 (file)
@@ -215,7 +215,7 @@ static void aspeed_gfx_disable_vblank(struct drm_simple_display_pipe *pipe)
        writel(reg | CRT_CTRL_VERTICAL_INTR_STS, priv->base + CRT_CTRL1);
 }
 
-static struct drm_simple_display_pipe_funcs aspeed_gfx_funcs = {
+static const struct drm_simple_display_pipe_funcs aspeed_gfx_funcs = {
        .enable         = aspeed_gfx_pipe_enable,
        .disable        = aspeed_gfx_pipe_disable,
        .update         = aspeed_gfx_pipe_update,