]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commitdiff
[media] drivers/media/pci/dm1105/dm1105.c: fix error return code
authorPeter Senna Tschudin <peter.senna@gmail.com>
Thu, 6 Sep 2012 14:23:55 +0000 (11:23 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 22 Nov 2012 16:20:28 +0000 (14:20 -0200)
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/pci/dm1105/dm1105.c

index d0dfa5d07e3316d505b2c1268b771022c6d3b495..f288ffcc4b6bb9004941d75830c2b90e393d2565 100644 (file)
@@ -1128,8 +1128,10 @@ static int __devinit dm1105_probe(struct pci_dev *pdev,
        INIT_WORK(&dev->work, dm1105_dmx_buffer);
        sprintf(dev->wqn, "%s/%d", dvb_adapter->name, dvb_adapter->num);
        dev->wq = create_singlethread_workqueue(dev->wqn);
-       if (!dev->wq)
+       if (!dev->wq) {
+               ret = -ENOMEM;
                goto err_dvb_net;
+       }
 
        ret = request_irq(pdev->irq, dm1105_irq, IRQF_SHARED,
                                                DRIVER_NAME, dev);