]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commitdiff
clk: mediatek: Initialize clk_init_data
authorRicky Liang <jcliang@chromium.org>
Mon, 18 May 2015 14:00:26 +0000 (22:00 +0800)
committerStephen Boyd <sboyd@codeaurora.org>
Wed, 20 May 2015 01:40:48 +0000 (18:40 -0700)
The variable init (struct clk_init_data) is allocated on the stack.
We weren't initializing the .flags field, so it contains random junk,
which can cause all kinds of interesting issues when the flags are
parsed by clk_register.

Signed-off-by: Ricky Liang <jcliang@chromium.org>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/mediatek/clk-gate.c
drivers/clk/mediatek/clk-pll.c

index 9d77ee3256f220718918bb5db0d7ff5b112742e0..57020368a6934a490695fe174954c8485fdd2cc3 100644 (file)
@@ -109,7 +109,7 @@ struct clk *mtk_clk_register_gate(
 {
        struct mtk_clk_gate *cg;
        struct clk *clk;
-       struct clk_init_data init;
+       struct clk_init_data init = {};
 
        cg = kzalloc(sizeof(*cg), GFP_KERNEL);
        if (!cg)
index 66154caf992adeed789ac7bed47c7b20369b5076..44409e98c52f5b112889a6458189cad87a5f2898 100644 (file)
@@ -268,7 +268,7 @@ static struct clk *mtk_clk_register_pll(const struct mtk_pll_data *data,
                void __iomem *base)
 {
        struct mtk_clk_pll *pll;
-       struct clk_init_data init;
+       struct clk_init_data init = {};
        struct clk *clk;
        const char *parent_name = "clk26m";