]> git.proxmox.com Git - pve-manager.git/commitdiff
aplinfo: use explicit defined checks
authorFabian Grünbichler <f.gruenbichler@proxmox.com>
Wed, 24 Aug 2016 10:27:42 +0000 (12:27 +0200)
committerDietmar Maurer <dietmar@proxmox.com>
Wed, 24 Aug 2016 11:08:45 +0000 (13:08 +0200)
a checksum of '0' can never be correct, but this makes the code clearer

PVE/API2/Nodes.pm

index 96cec229f134d520ff8c970c45799b5a2b2255f7..6db6caf25edac11823e3dd117220a937da8e7874 100644 (file)
@@ -1116,10 +1116,12 @@ __PACKAGE__->register_method({
                eval {
                    open(my $fh, '<', $filename) or die "Can't open '$filename': $!";
                    binmode($fh);
-                   if ($expected = $template_info->{sha512sum}) {
+                   if (defined($template_info->{sha512sum})) {
+                       $expected = $template_info->{sha512sum};
                        $digest = Digest::SHA->new(512)->addfile($fh)->hexdigest;
-                   } elsif ($expected = $template_info->{md5sum}) {
+                   } elsif (defined($template_info->{md5sum})) {
                        #fallback to MD5
+                       $expected = $template_info->{md5sum};
                        $digest = Digest::MD5->new->addfile($fh)->hexdigest;
                    } else {
                        die "no expected checksum defined";