]> git.proxmox.com Git - proxmox-backup.git/commitdiff
ui: Dashboard/TaskSummary: refactor types and title
authorDominik Csapak <d.csapak@proxmox.com>
Tue, 6 Oct 2020 10:25:26 +0000 (12:25 +0200)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Tue, 6 Oct 2020 10:58:52 +0000 (12:58 +0200)
by moving the definition into the controller and dynamically use them
in the updateTasks function

we will reuse/extend this later

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
www/dashboard/TaskSummary.js

index 0cf049cdfb9f7ca6cff98aae2807807de2e10a18..c50957510834b9fa1016c056331c49974ad23e04 100644 (file)
@@ -7,6 +7,20 @@ Ext.define('PBS.TaskSummary', {
     controller: {
        xclass: 'Ext.app.ViewController',
 
+       types: [
+           "backup",
+           "prune",
+           "garbage_collection",
+           "sync",
+       ],
+
+       titles: {
+           "backup": gettext('Backups'),
+           "prune": gettext('Prunes'),
+           "garbage_collection": gettext('Garbage collections'),
+           "sync": gettext('Syncs'),
+       },
+
        render_icon: function(state, count) {
            let cls = 'question';
            let color = 'faded';
@@ -40,18 +54,15 @@ Ext.define('PBS.TaskSummary', {
        },
     },
 
-    updateTasks: function(data) {
+    updateTasks: function(source) {
        let me = this;
-       data.backup.type = gettext('Backups');
-       data.prune.type = gettext('Prunes');
-       data.garbage_collection.type = gettext('Garbage collections');
-       data.sync.type = gettext('Syncs');
-       me.lookup('grid').getStore().setData([
-           data.backup,
-           data.prune,
-           data.garbage_collection,
-           data.sync,
-       ]);
+       let controller = me.getController();
+       let data = [];
+       controller.types.forEach((type) => {
+           source[type].type = controller.titles[type];
+           data.push(source[type]);
+       });
+       me.lookup('grid').getStore().setData(data);
     },
 
     layout: 'fit',