ALSA: usb-audio: Handle the error from snd_usb_mixer_apply_create_quirk()

BugLink: https://bugs.launchpad.net/bugs/1863019
[ Upstream commit 328e9f6973be2ee67862cb17bf6c0c5c5918cd72 ]

The error from snd_usb_mixer_apply_create_quirk() is ignored in the
current usb-audio driver code, which will continue the probing even
after the error.  Let's take it more serious.

Fixes: 7b1eda223deb ("ALSA: usb-mixer: factor out quirks")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>

diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
index e69bbf5dd66af80d0c13f869c8601718261f2a4c..27e823479e566757314d7d01d5b5886ec796de21 100644 (file)
--- a/sound/usb/mixer.c
+++ b/sound/usb/mixer.c
@@ -2637,7 +2637,9 @@ int snd_usb_create_mixer(struct snd_usb_audio *chip, int ctrlif,
            (err = snd_usb_mixer_status_create(mixer)) < 0)
                goto _error;
 
-       snd_usb_mixer_apply_create_quirk(mixer);
+       err = snd_usb_mixer_apply_create_quirk(mixer);
+       if (err < 0)
+               goto _error;
 
        err = snd_device_new(chip->card, SNDRV_DEV_CODEC, mixer, &dev_ops);
        if (err < 0)