]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
scsi: pm80xx: Fix error return in pm8001_pci_probe()
authorZhang Qilong <zhangqilong3@huawei.com>
Sat, 5 Dec 2020 11:55:51 +0000 (19:55 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 7 Dec 2020 22:35:10 +0000 (17:35 -0500)
The driver did not return an error in the case where
pm8001_configure_phy_settings() failed.

Use rc to store the return value of pm8001_configure_phy_settings().

Link: https://lore.kernel.org/r/20201205115551.2079471-1-zhangqilong3@huawei.com
Fixes: 279094079a44 ("[SCSI] pm80xx: Phy settings support for motherboard controller.")
Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/pm8001/pm8001_init.c

index 9a5d284f076a4b707546011bc18bb85fa448fd7b..ee2de177d0d0d28c7559f9adc29b2d9aebebca62 100644 (file)
@@ -1127,7 +1127,8 @@ static int pm8001_pci_probe(struct pci_dev *pdev,
 
        pm8001_init_sas_add(pm8001_ha);
        /* phy setting support for motherboard controller */
-       if (pm8001_configure_phy_settings(pm8001_ha))
+       rc = pm8001_configure_phy_settings(pm8001_ha);
+       if (rc)
                goto err_out_shost;
 
        pm8001_post_sas_ha_init(shost, chip);