]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
ASoC: Intel: fix error code cnl_set_dsp_D0()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 11 Dec 2020 10:06:52 +0000 (13:06 +0300)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 19 Feb 2021 15:44:54 +0000 (16:44 +0100)
BugLink: https://bugs.launchpad.net/bugs/1914654
commit f373a811fd9a69fc8bafb9bcb41d2cfa36c62665 upstream.

Return -ETIMEDOUT if the dsp boot times out instead of returning
success.

Fixes: cb6a55284629 ("ASoC: Intel: cnl: Add sst library functions for cnl platform")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/X9NEvCzuN+IObnTN@mwanda
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: William Breathitt Gray <william.gray@canonical.com>
sound/soc/intel/skylake/cnl-sst.c

index c6abcd5aa67b96201d2d8a9dcb611e6dafb31c09..e808f62960ba7df27944a31ad53ebdc2603d9180 100644 (file)
@@ -224,6 +224,7 @@ static int cnl_set_dsp_D0(struct sst_dsp *ctx, unsigned int core_id)
                                "dsp boot timeout, status=%#x error=%#x\n",
                                sst_dsp_shim_read(ctx, CNL_ADSP_FW_STATUS),
                                sst_dsp_shim_read(ctx, CNL_ADSP_ERROR_CODE));
+                       ret = -ETIMEDOUT;
                        goto err;
                }
        } else {