]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
mm/page_alloc.c: micro-optimisation Remove unnecessary branch
authorMateusz Nosek <mateusznosek0@gmail.com>
Thu, 2 Apr 2020 04:09:53 +0000 (21:09 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 2 Apr 2020 16:35:31 +0000 (09:35 -0700)
Previously if branch condition was false, the assignment was not executed.
The assignment can be safely executed even when the condition is false
and it is not incorrect as it assigns the value of 'nodemask' to
'ac.nodemask' which already has the same value.

So as the assignment can be executed unconditionally, the branch can be
removed.

Signed-off-by: Mateusz Nosek <mateusznosek0@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Link: http://lkml.kernel.org/r/20200307225335.31300-1-mateusznosek0@gmail.com
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/page_alloc.c

index 2a7d77b0160431cd83ca07d04cdffeb2f9be2627..43a405c4c16e2424a8a448a5ee6281f150ce7ef6 100644 (file)
@@ -4751,8 +4751,7 @@ __alloc_pages_nodemask(gfp_t gfp_mask, unsigned int order, int preferred_nid,
         * Restore the original nodemask if it was potentially replaced with
         * &cpuset_current_mems_allowed to optimize the fast-path attempt.
         */
-       if (unlikely(ac.nodemask != nodemask))
-               ac.nodemask = nodemask;
+       ac.nodemask = nodemask;
 
        page = __alloc_pages_slowpath(alloc_mask, order, &ac);