]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
dpaa2-eth: fix error return code in setup_dpni()
authorWei Yongjun <weiyongjun1@huawei.com>
Mon, 27 Apr 2020 10:43:22 +0000 (10:43 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 1 May 2020 03:40:31 +0000 (20:40 -0700)
Fix to return negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c

index 8ec435ba7d27389c318494d6d63f8b5e74dffdf6..11accab81ea189542a4491066cb757664c21a7b5 100644 (file)
@@ -2702,8 +2702,10 @@ static int setup_dpni(struct fsl_mc_device *ls_dev)
 
        priv->cls_rules = devm_kzalloc(dev, sizeof(struct dpaa2_eth_cls_rule) *
                                       dpaa2_eth_fs_count(priv), GFP_KERNEL);
-       if (!priv->cls_rules)
+       if (!priv->cls_rules) {
+               err = -ENOMEM;
                goto close;
+       }
 
        return 0;