]> git.proxmox.com Git - mirror_qemu.git/commitdiff
hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_write
authorRichard Henderson <richard.henderson@linaro.org>
Mon, 12 Jul 2021 20:04:37 +0000 (20:04 +0000)
committerRichard Henderson <richard.henderson@linaro.org>
Mon, 26 Jul 2021 17:07:07 +0000 (07:07 -1000)
From clang-13:
hw/pci-host/pnv_phb4.c:375:18: error: variable 'v' set but not used \
    [-Werror,-Wunused-but-set-variable]

It's pretty clear that we meant to write back 'v' after
all that computation and not 'val'.

Acked-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
hw/pci-host/pnv_phb4.c

index 54f57c660a94bc93f6207995fbdd480262536545..5c375a9f285dc74978aae8760451b94bb075ade3 100644 (file)
@@ -392,7 +392,7 @@ static void pnv_phb4_ioda_write(PnvPHB4 *phb, uint64_t val)
             v &= 0xffffffffffff0000ull;
             v |= 0x000000000000cfffull & val;
         }
-        *tptr = val;
+        *tptr = v;
         break;
     }
     case IODA3_TBL_MBT: