[ospfd] fix rare leak of struct connected, in an error path.

2006-01-10 Juris Kalnins <juris@mt.lv>

	* ospf_zebra.c: (ospf_interface_address_delete) fix rare leak of
	  struct connected in an error case.

diff --git a/ospfd/ChangeLog b/ospfd/ChangeLog
index 10a5de6a15895726f1b3d81509eb9531fccb5370..35d353e56f4b37a96678c7261aa0ee822a346d7f 100644 (file)
--- a/ospfd/ChangeLog
+++ b/ospfd/ChangeLog
@@ -1,3 +1,8 @@
+2006-01-10 Juris Kalnins <juris@mt.lv>
+
+       * ospf_zebra.c: (ospf_interface_address_delete) fix rare leak of 
+         struct connected in an error case.
+
 2006-01-10 Paul Jakma <paul.jakma@sun.com>
 
        * ospfd.c: (ospf_network_run) checking to see if router-id

diff --git a/ospfd/ospf_zebra.c b/ospfd/ospf_zebra.c
index af82e979a9ced9b4286f0b09c26976a6616bd34f..544a0d614812762efcb35795e55a1684095900fa 100644 (file)
--- a/ospfd/ospf_zebra.c
+++ b/ospfd/ospf_zebra.c
@@ -289,7 +289,10 @@ ospf_interface_address_delete (int command, struct zclient *zclient,
 
   rn = route_node_lookup (IF_OIFS (ifp), &p);
   if (!rn)
-    return 0;
+    {
+      connected_free (c);
+      return 0;
+    }
 
   assert (rn->info);
   oi = rn->info;