scsi: elx: libefc: Fix less than zero comparison of a unsigned int

The comparison of the u32 variable rc to less than zero always false
because it is unsigned. Fix this by making it an int.

Link: https://lore.kernel.org/r/20210616170401.15831-1-colin.king@canonical.com
Fixes: 202bfdffae27 ("scsi: elx: libefc: FC node ELS and state handling")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Addresses-Coverity: ("Unsigned compared against 0")

diff --git a/drivers/scsi/elx/libefc/efc_device.c b/drivers/scsi/elx/libefc/efc_device.c
index 31a688bce6e93aa0b3f58c217371235b5dc1d332..725ca2a23fb2a39c855d54d7f670820e28809648 100644 (file)
--- a/drivers/scsi/elx/libefc/efc_device.c
+++ b/drivers/scsi/elx/libefc/efc_device.c
@@ -15,7 +15,7 @@
 void
 efc_d_send_prli_rsp(struct efc_node *node, u16 ox_id)
 {
-       u32 rc = EFC_SCSI_CALL_COMPLETE;
+       int rc = EFC_SCSI_CALL_COMPLETE;
        struct efc *efc = node->efc;
 
        node->ls_acc_oxid = ox_id;