]> git.proxmox.com Git - mirror_qemu.git/commitdiff
pci-assign: use monitor_handle_fd_param
authorPaolo Bonzini <pbonzini@redhat.com>
Thu, 20 Sep 2012 14:50:32 +0000 (16:50 +0200)
committerLuiz Capitulino <lcapitulino@redhat.com>
Wed, 26 Sep 2012 15:42:19 +0000 (12:42 -0300)
There is no need to open-code the choice between a file descriptor
number or a named one.  Just use monitor_handle_fd_param, which
also takes care of printing the error message.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
hw/kvm/pci-assign.c

index 05b93d9a51f12e37e92e93a6d390f0fc66cd76ab..7a0998c518d86b5a3b706a35a7fe6a3bf6a68967 100644 (file)
@@ -579,15 +579,9 @@ static int get_real_device(AssignedDevice *pci_dev, uint16_t r_seg,
     snprintf(name, sizeof(name), "%sconfig", dir);
 
     if (pci_dev->configfd_name && *pci_dev->configfd_name) {
-        if (qemu_isdigit(pci_dev->configfd_name[0])) {
-            dev->config_fd = strtol(pci_dev->configfd_name, NULL, 0);
-        } else {
-            dev->config_fd = monitor_get_fd(cur_mon, pci_dev->configfd_name);
-            if (dev->config_fd < 0) {
-                error_report("%s: (%s) unkown", __func__,
-                             pci_dev->configfd_name);
-                return 1;
-            }
+        dev->config_fd = monitor_handle_fd_param(cur_mon, pci_dev->configfd_name);
+        if (dev->config_fd < 0) {
+            return 1;
         }
     } else {
         dev->config_fd = open(name, O_RDWR);