]> git.proxmox.com Git - mirror_ovs.git/commitdiff
conntrack: Fix NULL pointer dereference.
authorWilliam Tu <u9012063@gmail.com>
Tue, 17 Mar 2020 23:12:21 +0000 (16:12 -0700)
committerWilliam Tu <u9012063@gmail.com>
Thu, 19 Mar 2020 23:59:23 +0000 (16:59 -0700)
Coverity CID 279957 reports NULL pointer derefence when
'conn' is NULL and calling ct_print_conn_info.

Cc: Usman Ansari <uansari@vmware.com>
Signed-off-by: William Tu <u9012063@gmail.com>
Acked-by: Dumitru Ceara <dceara@redhat.com>
lib/conntrack.c

index ff5a89457c0ad507c5a64d3a4c66589182f07daa..001a37ff6aff663e51fff9b0468aa9b371e2b0a9 100644 (file)
@@ -1302,7 +1302,7 @@ process_one(struct conntrack *ct, struct dp_packet *pkt,
             if (!conn) {
                 pkt->md.ct_state |= CS_TRACKED | CS_INVALID;
                 char *log_msg = xasprintf("Missing master conn %p", rev_conn);
-                ct_print_conn_info(conn, log_msg, VLL_INFO, true, true);
+                ct_print_conn_info(rev_conn, log_msg, VLL_INFO, true, true);
                 free(log_msg);
                 return;
             }