]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
sched: correct SD_flags returned by tl->sd_flags()
authorPeng Liu <iwtbavbm@gmail.com>
Tue, 9 Jun 2020 15:09:36 +0000 (23:09 +0800)
committerPeter Zijlstra <peterz@infradead.org>
Mon, 15 Jun 2020 12:10:04 +0000 (14:10 +0200)
During sched domain init, we check whether non-topological SD_flags are
returned by tl->sd_flags(), if found, fire a waning and correct the
violation, but the code failed to correct the violation. Correct this.

Fixes: 143e1e28cb40 ("sched: Rework sched_domain topology definition")
Signed-off-by: Peng Liu <iwtbavbm@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
Link: https://lkml.kernel.org/r/20200609150936.GA13060@iZj6chx1xj0e0buvshuecpZ
kernel/sched/topology.c

index ba81187bb7af10ce628956f5f822e28d8ce952fd..9079d865a93571424cb7bc8c1ddaec5999603f1b 100644 (file)
@@ -1328,7 +1328,7 @@ sd_init(struct sched_domain_topology_level *tl,
                sd_flags = (*tl->sd_flags)();
        if (WARN_ONCE(sd_flags & ~TOPOLOGY_SD_FLAGS,
                        "wrong sd_flags in topology description\n"))
-               sd_flags &= ~TOPOLOGY_SD_FLAGS;
+               sd_flags &= TOPOLOGY_SD_FLAGS;
 
        /* Apply detected topology flags */
        sd_flags |= dflags;