]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
spi: clps711x: Don't call kfree() after spi_master_put/spi_unregister_master
authorAxel Lin <axel.lin@ingics.com>
Tue, 10 Sep 2013 02:19:29 +0000 (10:19 +0800)
committerMark Brown <broonie@linaro.org>
Tue, 10 Sep 2013 10:28:22 +0000 (11:28 +0100)
Calling kfree() to clean up the memory obtained from spi_alloc_master() is
wrong as this is done in spi_master_release() when spi_master->dev's refcount
reaches zero.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/spi/spi-clps711x.c

index 5655acf55bfe35a7d4f0fcb853e56435b4e847c9..b597a92565dc7e99f6d466de8788ebac92319af1 100644 (file)
@@ -247,7 +247,6 @@ err_out:
                        gpio_free(hw->chipselect[i]);
 
        spi_master_put(master);
-       kfree(master);
 
        return ret;
 }
@@ -263,7 +262,6 @@ static int spi_clps711x_remove(struct platform_device *pdev)
                        gpio_free(hw->chipselect[i]);
 
        spi_unregister_master(master);
-       kfree(master);
 
        return 0;
 }