]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
md/raid5-cache: remove unnecessary function parameters
authorJackieLiu <liuyun01@kylinos.cn>
Mon, 28 Nov 2016 08:19:18 +0000 (16:19 +0800)
committerShaohua Li <shli@fb.com>
Tue, 29 Nov 2016 22:46:21 +0000 (14:46 -0800)
The function parameter 'recovery_list' is not used in
body, we can delete it

Signed-off-by: JackieLiu <liuyun01@kylinos.cn>
Reviewed-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Shaohua Li <shli@fb.com>
drivers/md/raid5-cache.c

index b34b26dd3e453d547e82051997dd260509283612..1842ecbf95a10acd69f69d86681ca78aa4ca217a 100644 (file)
@@ -67,7 +67,7 @@ static char *r5c_journal_mode_str[] = {"write-through",
 /*
  * raid5 cache state machine
  *
- * With rhe RAID cache, each stripe works in two phases:
+ * With the RAID cache, each stripe works in two phases:
  *     - caching phase
  *     - writing-out phase
  *
@@ -1674,7 +1674,6 @@ out:
 
 static struct stripe_head *
 r5c_recovery_alloc_stripe(struct r5conf *conf,
-                         struct list_head *recovery_list,
                          sector_t stripe_sect,
                          sector_t log_start)
 {
@@ -1855,8 +1854,7 @@ r5c_recovery_analyze_meta_block(struct r5l_log *log,
                                                stripe_sect);
 
                if (!sh) {
-                       sh = r5c_recovery_alloc_stripe(conf, cached_stripe_list,
-                                                      stripe_sect, ctx->pos);
+                       sh = r5c_recovery_alloc_stripe(conf, stripe_sect, ctx->pos);
                        /*
                         * cannot get stripe from raid5_get_active_stripe
                         * try replay some stripes
@@ -1865,8 +1863,7 @@ r5c_recovery_analyze_meta_block(struct r5l_log *log,
                                r5c_recovery_replay_stripes(
                                        cached_stripe_list, ctx);
                                sh = r5c_recovery_alloc_stripe(
-                                       conf, cached_stripe_list,
-                                       stripe_sect, ctx->pos);
+                                       conf, stripe_sect, ctx->pos);
                        }
                        if (!sh) {
                                pr_debug("md/raid:%s: Increasing stripe cache size to %d to recovery data on journal.\n",
@@ -1875,8 +1872,7 @@ r5c_recovery_analyze_meta_block(struct r5l_log *log,
                                raid5_set_cache_size(mddev,
                                                     conf->min_nr_stripes * 2);
                                sh = r5c_recovery_alloc_stripe(
-                                       conf, cached_stripe_list, stripe_sect,
-                                       ctx->pos);
+                                       conf, stripe_sect, ctx->pos);
                        }
                        if (!sh) {
                                pr_err("md/raid:%s: Cannot get enough stripes due to memory pressure. Recovery failed.\n",