]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
drm/omap: cleanup OMAP_BO flags
authorTomi Valkeinen <tomi.valkeinen@ti.com>
Thu, 10 Oct 2019 11:59:56 +0000 (13:59 +0200)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Fri, 11 Oct 2019 14:02:28 +0000 (17:02 +0300)
Reorder OMAP_BO flags and improve the comments.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191010120000.1421-5-jjhiblot@ti.com
include/uapi/drm/omap_drm.h

index 1fccffef9e27297e61f59f092c809485f9fb507f..d8ee2f840697b2d5027ed1a61d69c4b6d04b5160 100644 (file)
@@ -38,19 +38,20 @@ struct drm_omap_param {
        __u64 value;                    /* in (set_param), out (get_param) */
 };
 
-#define OMAP_BO_SCANOUT                0x00000001      /* scanout capable (phys contiguous) */
-#define OMAP_BO_CACHE_MASK     0x00000006      /* cache type mask, see cache modes */
-#define OMAP_BO_TILED_MASK     0x00000f00      /* tiled mapping mask, see tiled modes */
+/* Scanout buffer, consumable by DSS */
+#define OMAP_BO_SCANOUT                0x00000001
 
-/* cache modes */
-#define OMAP_BO_CACHED         0x00000000      /* default */
-#define OMAP_BO_WC             0x00000002      /* write-combine */
-#define OMAP_BO_UNCACHED       0x00000004      /* strongly-ordered (uncached) */
+/* Buffer CPU caching mode: cached, write-combining or uncached. */
+#define OMAP_BO_CACHED         0x00000000
+#define OMAP_BO_WC             0x00000002
+#define OMAP_BO_UNCACHED       0x00000004
+#define OMAP_BO_CACHE_MASK     0x00000006
 
-/* tiled modes */
+/* Use TILER for the buffer. The TILER container unit can be 8, 16 or 32 bits. */
 #define OMAP_BO_TILED_8                0x00000100
 #define OMAP_BO_TILED_16       0x00000200
 #define OMAP_BO_TILED_32       0x00000300
+#define OMAP_BO_TILED_MASK     0x00000f00
 #define OMAP_BO_TILED          (OMAP_BO_TILED_8 | OMAP_BO_TILED_16 | OMAP_BO_TILED_32)
 
 union omap_gem_size {