]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
clk: tegra: tegra124-emc: Fix missing put_device() call in emc_ensure_emc_driver
authorMiaoqian Lin <linmq006@gmail.com>
Wed, 12 Jan 2022 10:45:01 +0000 (10:45 +0000)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 27 Apr 2022 09:58:09 +0000 (11:58 +0200)
BugLink: https://bugs.launchpad.net/bugs/1969110
[ Upstream commit 6d6ef58c2470da85a99119f74d34216c8074b9f0 ]

The reference taken by 'of_find_device_by_node()' must be released when
not needed anymore.
Add the corresponding 'put_device()' in the error handling path.

Fixes: 2db04f16b589 ("clk: tegra: Add EMC clock driver")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20220112104501.30655-1-linmq006@gmail.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit 613e1b253f6dfa9e68c14e2b7db1bf170ddff2e8)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/clk/tegra/clk-tegra124-emc.c

index 74c1d894cca864f0045c05826be93996c52cbddc..219c80653dbdb2e32ed9e9d0602e8b6cc5c90be7 100644 (file)
@@ -198,6 +198,7 @@ static struct tegra_emc *emc_ensure_emc_driver(struct tegra_clk_emc *tegra)
 
        tegra->emc = platform_get_drvdata(pdev);
        if (!tegra->emc) {
+               put_device(&pdev->dev);
                pr_err("%s: cannot find EMC driver\n", __func__);
                return NULL;
        }