]> git.proxmox.com Git - mirror_qemu.git/commitdiff
vl: Ensure the numa_post_machine_init func in the appropriate location
authorDou Liyang <douly.fnst@cn.fujitsu.com>
Tue, 17 Jan 2017 14:42:31 +0000 (22:42 +0800)
committerEduardo Habkost <ehabkost@redhat.com>
Mon, 23 Jan 2017 23:25:36 +0000 (21:25 -0200)
In the numa_post_machine_init(), we use CPU_FOREACH macro to set all
CPUs' namu_node. So, we should make sure that we call it after Qemu
has already initialied all the CPUs.

As we all know, the CPUs can be created by "-smp"(pc_new_cpu) or
"-device"(qdev_device_add) command. But, before the device init,
Qemu execute the numa_post_machine_init earlier. It makes the mapping
of NUMA nodes and CPUs incorrect.

The patch move the numa_post_machine_init func in the appropriate
location.

Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
Message-Id: <1484664152-24446-2-git-send-email-douly.fnst@cn.fujitsu.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
vl.c

diff --git a/vl.c b/vl.c
index a260f309748cbd1e1314d380b01554364d549dd2..ed1cbe9c73cead043760cc5c9c98cbdcbdb4763a 100644 (file)
--- a/vl.c
+++ b/vl.c
@@ -4513,8 +4513,6 @@ int main(int argc, char **argv, char **envp)
 
     cpu_synchronize_all_post_init();
 
-    numa_post_machine_init();
-
     if (hax_enabled()) {
         hax_sync_vcpus();
     }
@@ -4539,6 +4537,9 @@ int main(int argc, char **argv, char **envp)
                           device_init_func, NULL, NULL)) {
         exit(1);
     }
+
+    numa_post_machine_init();
+
     rom_reset_order_override();
 
     /* Did we create any drives that we failed to create a device for? */