PMG::Cluster::sync_generic_mtime_db - correctly start/commit transaction

No need to start transaction if there is no data

diff --git a/PMG/Cluster.pm b/PMG/Cluster.pm
index be1ac9d6e40aa20a786756996d95812e7de65b5a..af51d754665b64bd5350202d61a76529d987b01b 100644 (file)
--- a/PMG/Cluster.pm
+++ b/PMG/Cluster.pm
@@ -657,17 +657,18 @@ my $sync_generic_mtime_db = sub {
     eval {
        # use transaction to speedup things
        my $max = 1000; # UPDATE MAX ENTRIES AT ONCE
-       $ldb->begin_work;
        my $count = 0;
        while (my $ref = $sth->fetchrow_hashref()) {
+           $ldb->begin_work if !$count;
+           $mergefunc->($ref);
            if (++$count >= $max) {
                $count = 0;
                $ldb->commit;
-               $ldb->begin_work;
            }
-           $mergefunc->($ref);
            $updates++;
        }
+
+       $ldb->commit if $count;
     };
     if (my $err = $@) {
        $ldb->rollback;