]> git.proxmox.com Git - qemu.git/commitdiff
Fix obvious mistake in pxa2xx i2s driver
authorVasily Khoruzhick <anarsoul@gmail.com>
Sun, 20 Feb 2011 19:23:59 +0000 (21:23 +0200)
committerAurelien Jarno <aurelien@aurel32.net>
Sun, 20 Feb 2011 19:28:45 +0000 (20:28 +0100)
RST bit is (1 << 4) bit, not (1 << 3), fix condition
that enables i2s if ENB is set and RST is not set.

Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
hw/pxa2xx.c

index 9ebbce60d71cc9228192dc0efe0a6e30456619f6..dc595f332a1b6b9b144c8ee0f17e3102d0081a26 100644 (file)
@@ -1661,7 +1661,7 @@ static void pxa2xx_i2s_write(void *opaque, target_phys_addr_t addr,
         }
         if (value & (1 << 4))                          /* EFWR */
             printf("%s: Attempt to use special function\n", __FUNCTION__);
-        s->enable = ((value ^ 4) & 5) == 5;            /* ENB && !RST*/
+        s->enable = (value & 9) == 1;                  /* ENB && !RST*/
         pxa2xx_i2s_update(s);
         break;
     case SACR1: