]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
ALSA: usb-audio: Fix the first PCM interface assignment
authorTakashi Iwai <tiwai@suse.de>
Fri, 6 Jul 2012 06:11:43 +0000 (08:11 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 6 Jul 2012 06:11:43 +0000 (08:11 +0200)
In the new PCM streaming logic, the interface number is assigned to
usb stream instance (subs->interface) after the format and rate setups
are succeeded, but some codes are still passing subs->interface as the
reference to helper functions.  This leads to initializing with an
invalid iface number (-1).

This patch replaces the wrong references with the ones from the target
fmt correctly.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/pcm.c

index 54607f8c4f66ca91e5502808aa9fc94ceebc4d76..f0ede134a111853029d9efbc91aadd45e3aa254d 100644 (file)
@@ -387,7 +387,7 @@ add_sync_ep:
                subs->data_endpoint->sync_master = subs->sync_endpoint;
        }
 
-       if ((err = snd_usb_init_pitch(subs->stream->chip, subs->interface, alts, fmt)) < 0)
+       if ((err = snd_usb_init_pitch(subs->stream->chip, fmt->iface, alts, fmt)) < 0)
                return err;
 
        subs->cur_audiofmt = fmt;
@@ -450,7 +450,7 @@ static int snd_usb_hw_params(struct snd_pcm_substream *substream,
                struct usb_interface *iface;
                iface = usb_ifnum_to_if(subs->dev, fmt->iface);
                alts = &iface->altsetting[fmt->altset_idx];
-               ret = snd_usb_init_sample_rate(subs->stream->chip, subs->interface, alts, fmt, rate);
+               ret = snd_usb_init_sample_rate(subs->stream->chip, fmt->iface, alts, fmt, rate);
                if (ret < 0)
                        return ret;
                subs->cur_rate = rate;