]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
media: usb: Check az6007_read() return value
authorDaniil Dulov <d.dulov@aladdin.ru>
Tue, 14 Mar 2023 17:04:49 +0000 (10:04 -0700)
committerRoxana Nicolescu <roxana.nicolescu@canonical.com>
Mon, 2 Oct 2023 15:19:54 +0000 (17:19 +0200)
BugLink: https://bugs.launchpad.net/bugs/2034469
[ Upstream commit fdaca63186f59fc664b346c45b76576624b48e57 ]

If az6007_read() returns error, there is no sence to continue.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 3af2f4f15a61 ("[media] az6007: Change the az6007 read/write routine parameter")
Signed-off-by: Daniil Dulov <d.dulov@aladdin.ru>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/media/usb/dvb-usb-v2/az6007.c

index 62ee09f28a0bc115b2eadd5ec0596d2216018cb6..7524c90f5da61d4fe01b638cfd77047f4f0bb476 100644 (file)
@@ -202,7 +202,8 @@ static int az6007_rc_query(struct dvb_usb_device *d)
        unsigned code;
        enum rc_proto proto;
 
-       az6007_read(d, AZ6007_READ_IR, 0, 0, st->data, 10);
+       if (az6007_read(d, AZ6007_READ_IR, 0, 0, st->data, 10) < 0)
+               return -EIO;
 
        if (st->data[1] == 0x44)
                return 0;