]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
drm/mgag200: fix a test in mga_vga_mode_valid()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 25 Jan 2018 14:26:55 +0000 (17:26 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 30 Jan 2018 17:05:25 +0000 (18:05 +0100)
The parentheses are in the wrong place here so we pass the bits per
pixel as zero.

Fixes: abbee6238775 ("drm/mgag200: Added resolution and bandwidth limits for various G200e products.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20180125142655.GA23885@mwanda
drivers/gpu/drm/mgag200/mgag200_mode.c

index 68e5d9c94475e4b83b1408034062db8b653026b9..fb50a9ddaae86266bbd6410c901a68d92e005f05 100644 (file)
@@ -1620,8 +1620,8 @@ static int mga_vga_mode_valid(struct drm_connector *connector,
                        return MODE_VIRTUAL_X;
                if (mode->vdisplay > 1024)
                        return MODE_VIRTUAL_Y;
-               if (mga_vga_calculate_mode_bandwidth(mode,
-                       bpp > (31877 * 1024)))
+               if (mga_vga_calculate_mode_bandwidth(mode, bpp) >
+                   (31877 * 1024))
                        return MODE_BANDWIDTH;
        } else if (mdev->type == G200_EV &&
                (mga_vga_calculate_mode_bandwidth(mode, bpp)