]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
ACPI, x86: Fix extended error log driver to depend on CONFIG_X86_LOCAL_APIC
authorLuck, Tony <tony.luck@intel.com>
Fri, 8 Nov 2013 22:03:33 +0000 (14:03 -0800)
committerIngo Molnar <mingo@kernel.org>
Mon, 11 Nov 2013 09:21:29 +0000 (10:21 +0100)
Randconfig build by Fengguang's robot army reported:

   drivers/built-in.o: In function `extlog_print':
   >> acpi_extlog.c:(.text+0xcc719): undefined reference to `boot_cpu_physical_apicid'

The config had CONFIG_SMP=n so we picked up this definition from:

  <asm/cpu.h>: #define cpu_physical_id(cpu) boot_cpu_physical_apicid

But boot_cpu_physical_apicid is defined in arch/x86/kernel/apic/apic.c
which is only built if CONFIG_X86_LOCAL_APIC=y.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Cc: Chen Gong <gong.chen@linux.intel.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Link: http://lkml.kernel.org/r/6be3afdcad7968f7fb7c0b681e547b3e872e44dd.1383947368.git.tony.luck@intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
drivers/acpi/Kconfig

index 08eadb4a57cb66008ddfc1530d5f0c1007015296..e11faae81ed9b9a0be91d0d8830f06df516ad6df 100644 (file)
@@ -374,7 +374,7 @@ source "drivers/acpi/apei/Kconfig"
 
 config ACPI_EXTLOG
        tristate "Extended Error Log support"
-       depends on X86_MCE
+       depends on X86_MCE && X86_LOCAL_APIC
        select EFI
        select UEFI_CPER
        default n